Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token for audio dump #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add token for audio dump #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions components/popover.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
{
"popover": {
"comment": "Applied to popovers",
"figma": "https://www.figma.com/file/NaNrfXjygZtRgMfHAFHjsp/Components---Windows%2BWeb?node-id=5282%3A497",
"primary": {
"#normal": {
"background": "@theme-background-solid-primary-normal"
}
"popover": {
"comment": "Applied to popovers",
"figma": "https://www.figma.com/file/NaNrfXjygZtRgMfHAFHjsp/Components---Windows%2BWeb?node-id=5282%3A497",
"primary": {
"#normal": {
"background": "@theme-background-solid-primary-normal"
}
},
"audio-dump": {
"#normal": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audio dump is too specific in the popover component this should be added as secondary. Also this is already defined within modal which you could use

"background": "@theme-overlay-audiodump-primary-normal"
}
},
"audio-dump-file-record": {
"#normal": {
"background": "@theme-overlay-audiodump-secondary-normal"
}
}
}
}
}
8 changes: 8 additions & 0 deletions theme-data/dark/dark-common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@
"overlay": {
"meetings": {
"normal": "@color-black-alpha-70"
},
"audiodump": {
"primary": {
"normal": "@color-white-alpha-11"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the things needed by audiodump are already defined and i don't think needs to be added. Components should be general things that are used to build a feature.

"secondary": {
"normal": "@color-white-alpha-11"
}
}
},
"indicator": {
Expand Down
8 changes: 8 additions & 0 deletions theme-data/light/light-common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@
"overlay": {
"meetings": {
"normal": "@color-white-alpha-70"
},
"audiodump": {
"primary": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the theme-data colours should only be ones defined by ux. these have already been defined for example color-gray-10 is defined as "@theme-background-solid-secondary-normal" we should be using existing colours to build components from. We should not be adding to this file

"normal": "@color-gray-10"
},
"secondary": {
"normal": "@color-black-alpha-11"
}
}
},
"indicator": {
Expand Down
14 changes: 11 additions & 3 deletions theme-data/win-system-hc/win-system-hc-common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,17 @@
}
},
"overlay": {
"meetings": {
"normal": "@color-hc-PlaceholderColor"
}
"meetings": {
"normal": "@color-hc-PlaceholderColor"
},
"audiodump": {
"primary": {
"normal": "@color-hc-PlaceholderColor"
},
"secondary": {
"normal": "@color-hc-PlaceholderColor"
}
}
},
"button": {
"border": {
Expand Down