Add token for audio dump #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotNestor
reviewed
Mar 10, 2022
| @@ -203,6 +203,14 @@ | |||
| "overlay": { | |||
| "meetings": { | |||
| "normal": "@color-white-alpha-70" | |||
| }, | |||
| "audiodump": { | |||
| "primary": { | |||
There was a problem hiding this comment.
the theme-data colours should only be ones defined by ux. these have already been defined for example color-gray-10 is defined as "@theme-background-solid-secondary-normal" we should be using existing colours to build components from. We should not be adding to this file
NotNestor
reviewed
Mar 10, 2022
| } | ||
| }, | ||
| "audio-dump": { | ||
| "#normal": { |
There was a problem hiding this comment.
audio dump is too specific in the popover component this should be added as secondary. Also this is already defined within modal which you could use
NotNestor
reviewed
Mar 10, 2022
| "audiodump": { | ||
| "primary": { | ||
| "normal": "@color-white-alpha-11" | ||
| }, |
There was a problem hiding this comment.
most of the things needed by audiodump are already defined and i don't think needs to be added. Components should be general things that are used to build a feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide
This "Help" section can be deleted before submitting this pull request.
Update the name of this pull request to reflect the following shape:
Provide a general summary of the scope of the changes in this pull request.
Description
Add token for audio dump.
Links
Links to relevent resources.