Migrate to ESLint 9 #109
Migrate to ESLint 9 #109
Conversation
| 'jest', | ||
| 'cypress', | ||
| 'vitest' | ||
| )), |
There was a problem hiding this comment.
ESLint 9 requires to import plugins and presets. To avoiding having to declare presets both as an import as well as an item within this array, I've added a (type-checked) function that imports them by name.
An important aspect of this is that individual presets only execute when they are loaded (since the typescript preset depends on the typescript dependency, as well as the tailwind preset depends on the tailwindcss dependency).
| - Enable `@typescript-eslint/ban-ts-comment` (fixes #89) | ||
| - Upgrade available major versions of dependencies (`@typescript-eslint/eslint-plugin`) | ||
| - Add `molindo/tailwind` | ||
| - Enable `react/function-component-definition` to have auto fix for using functions of React components (fixes #75) |
There was a problem hiding this comment.
Prettier reindented this file.
| }, | ||
| "peerDependencies": { | ||
| "eslint": "^8.0.0" | ||
| "eslint": "^9.0.0" |
There was a problem hiding this comment.
Prettier is not a strict peer dependency technically, but strongly recommended (and kind of assumed). Not listing it here gives flexibility to consumers though, e.g. to use alternative formatters like Biome or Oxc.
| @@ -0,0 +1,26 @@ | |||
| // @ts-check | |||
There was a problem hiding this comment.
I think authoring the files in JavaScript is quite nice here to avoid a build step entirely. Still, we can use TypeScript to validate the types in our modules.
| names.map((name) => import(`./${name}.js`).then((mod) => mod.default)) | ||
| ); | ||
| return config.flat(); | ||
| } |
This reverts commit 0d66819.
| "prettier": "^3.0.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">=10" |
There was a problem hiding this comment.
is there any restriction on node, eg only >=20? Asking for a few nodejs@16 friends :)
There was a problem hiding this comment.
Ah yep, good point. I thought it might make sense to remove this.
eslint-config-molindo is flexible about Node.js, it only requires ESM support via .mjs (which is supported since Node.js 8.5).
However, ESLint 9 requires Node.js 18.8, so implicitly that is the lowest threshold. I thought removing this line might make sense, as we're essentially just repeating what ESLint has declared, and you'll already get a warning in older Node.js versions due to their engines setting.
For Node.js 16 apps, I guess it's ok to stay on ESLint 8 for the time being.
Does that sound reasonable to you?
There was a problem hiding this comment.
yes totally fine - thanks for clarifying.
| * @type {Array<import('eslint').Linter.Config>} | ||
| */ | ||
| export default [ | ||
| { |
There was a problem hiding this comment.
is it.only error already activated in the estlint-plugin-jest?
There was a problem hiding this comment.
That's the no-focused-tests rule below.
|
|
||
| /** | ||
| * @type {Array<import('eslint').Linter.Config>} | ||
| */ |
Adds support for ESLint 9 and also addresses various issues raised over time.
Fixes #108
Fixes #107
Fixes #106
Fixes #105
Fixes #102
Fixes #101
Fixes #99
Prerelease
Details
I've also added two PRs to potentially get rid of peer dependency warnings in yarn v1:
vitestpeer dependency optional vitest-dev/eslint-plugin-vitest#548tailwindcsspeer dependency optional francoismassart/eslint-plugin-tailwindcss#365In more recent npm versions, peer dependencies are automatically installed, therefore this doesn't pose a problem. The PRs would still help though, to avoid installing the dependencies in the first place.