Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running prettier separately #99

Closed
amannn opened this issue Apr 29, 2024 · 1 comment · Fixed by #109
Closed

Consider running prettier separately #99

amannn opened this issue Apr 29, 2024 · 1 comment · Fixed by #109

Comments

@amannn
Copy link
Member

amannn commented Apr 29, 2024

We currently run prettier as part of ESLint via eslint-plugin-prettier. The intention of this was to easily integrate Prettier with our toolchain, but this approach is no longer recommended. We might want to run prettier separately from ESLint.

An added benefit is that by requiring a .prettierrc file, we'd apply our formatting rules to other files that are not linted by ESLint (e.g. markdown, styles, …).

See also: https://prettier.io/docs/en/configuration.html#sharing-configurations

@amannn
Copy link
Member Author

amannn commented Jul 10, 2024

Related to this, molindo/tailwind use the official Prettier plugin instead of ESLint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant