Ship regexparam with optional wildcards
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `useRoute` is used with custom parser, parameter type should be specified explicitly as a generic argument.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
size-limit report 📦
|
|
@jeetiss I've decided not to create a workspace package, since it makes it harder to maintain builds and ship types. The code itself is 30 LOC, so I guess it is fine for the time being. I really hope that eventually it lands there, so we could remove the fix. |
jeetiss
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
src/regexparam.jswhich was extracted from https://github.com/lukeed/regexparamIt is a temporary fix until lukeed/regexparam#25 is shipped