-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional wildcards #25
Conversation
Hi @lukeed, just wanted to ask if you could take a brief look at this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 36 36
=========================================
Hits 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this :) It's a breaking change due to how the "/books/*?"
pattern will now match "/books"
(shown in test), but I think it's a change worth having.
Cutting this as a 3.0 release
@lukeed Thank you! We added it back as a dependency and it works well. molefrog/wouter#395 |
Closes #24