Update Phoenix to 1.7 #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamu Thanks for this. I'm going to pull this branch down and make a few additional commits to it to update the documentation in the README as well as one or two other small tweaks, but I want to keep this original PR so you get credit for your commits. We'll try to push this out today or tomorrow. We are currently working on a larger "in spirit Phoenix 1.7" update with a large rework of the templates and liveview integration, but unfortunately werent able to finish in time before Phoenix 1.7 officially released. I appreciate this PR and we'll get it in as a stop-gap so Torch is still usable on Phoenix 1.7 until the larger re-work is finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not really upgrade to Phoenix 1.7 in spirit, it just makes the minimum changes required to allow projects that use
torchto upgrade to Phoenix 1.7.I'm not sure how to QA this. The tests pass, and using this change on a Phoenix 1.7 project seems to work, including flashes (which I specifically checked because the behaviour changed between Phoenix 1.6 and Phoenix 1.7).
Resolves #356.