Support for phoenix 1.7

[alec-c4]

Are you planning to add support for phoenix 1.7? There are some breaking changes

❯ mix deps.compile torch
warning: the :phoenix compiler is no longer required in your mix.exs.

Please find the following line in your mix.exs and remove the :phoenix entry:

    compilers: [..., :phoenix, ...] ++ Mix.compilers(),

  (phoenix 1.7.0-rc.0) lib/mix/tasks/compile.phoenix.ex:8: Mix.Tasks.Compile.Phoenix.run/1
  (mix 1.14.2) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:92: Mix.Tasks.Compile.All.run_compiler/2
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:72: Mix.Tasks.Compile.All.compile/4
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:59: Mix.Tasks.Compile.All.with_logger_app/2
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:33: Mix.Tasks.Compile.All.run/1

warning: the :gettext compiler is no longer required in your mix.exs.

Please find the following line in your mix.exs and remove the :gettext entry:

    compilers: [..., :gettext, ...] ++ Mix.compilers(),

  (gettext 0.20.0) lib/mix/tasks/compile.gettext.ex:5: Mix.Tasks.Compile.Gettext.run/1
  (mix 1.14.2) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:92: Mix.Tasks.Compile.All.run_compiler/2
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:72: Mix.Tasks.Compile.All.compile/4
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:59: Mix.Tasks.Compile.All.with_logger_app/2
  (mix 1.14.2) lib/mix/tasks/compile.all.ex:33: Mix.Tasks.Compile.All.run/1
  (mix 1.14.2) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
  (mix 1.14.2) lib/mix/tasks/compile.ex:135: Mix.Tasks.Compile.run/1
  (mix 1.14.2) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
  (mix 1.14.2) lib/mix/tasks/deps.compile.ex:174: anonymous fn/2 in Mix.Tasks.Deps.Compile.do_mix/2
  (mix 1.14.2) lib/mix/project.ex:397: Mix.Project.in_project/4
  (elixir 1.14.2) lib/file.ex:1607: File.cd!/2
  (mix 1.14.2) lib/mix/dep.ex:271: Mix.Dep.in_dependency/3
  (mix 1.14.2) lib/mix/tasks/deps.compile.ex:90: anonymous fn/4 in Mix.Tasks.Deps.Compile.compile/2
  (elixir 1.14.2) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
  (mix 1.14.2) lib/mix/tasks/deps.compile.ex:80: Mix.Tasks.Deps.Compile.compile/2
  (mix 1.14.2) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
  (mix 1.14.2) lib/mix/cli.ex:84: Mix.CLI.run_task/2

==> torch
Compiling 2 files (.ex)

== Compilation error in file lib/torch/views/flash_view.ex ==
** (CompileError) lib/torch/views/flash_view.ex:6: module Phoenix.View is not loaded and could not be found. This may be happening because the module you are trying to load directly or indirectly depends on the current module
    (elixir 1.14.2) expanding macro: Kernel.use/2
    lib/torch/views/flash_view.ex:6: Torch.FlashView (module)
could not compile dependency :torch, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile torch", update it with "mix deps.update torch" or clean it with "mix deps.clean torch"

[cpjolicoeur]

Yes, we plan to be compatible with Phoenix 1.7. It has not yet been released and the first 1.7-rc was only released recently.

We'd love to get some help if you want help out and submit a Pull Request with 1.7 updates.

[sethkrasnianski]

Adding the release post here for posterity - https://www.phoenixframework.org/blog/phoenix-1.7-released

[cpjolicoeur]

Just as a follow-up, three different release candidates of Torch 5 have been released in the past few weeks/months that all support Phoenix 1.7. The most current release, as of this writing is 5.0.0-rc.2 available on hex.pm.

A full 5.0 release is still being worked on, but will include a lot more updates for LiveView and other newer features.

[cpjolicoeur]

closed via #384