Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoting service does not handle the partySubIdOrType in party #2103

Closed
2 tasks done
shashi165 opened this issue Mar 8, 2021 · 1 comment
Closed
2 tasks done

quoting service does not handle the partySubIdOrType in party #2103

shashi165 opened this issue Mar 8, 2021 · 1 comment
Assignees
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it triaged This bug has been triaged by the triage team!
Milestone

Comments

@shashi165
Copy link

shashi165 commented Mar 8, 2021

Summary:
The quoting service does not handle the partySubIdOrType in party, it gives below error

[dev1-quoting-service-57c765f8-78tsn quoting-service] (node:26) UnhandledPromiseRejectionWarning: FSPIOPError: Unsupported party identifier type '30' 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at Object.createFSPIOPError (/opt/quoting-service/node_modules/@mojaloop/central-services-error-handling/src/factory.js:198:12) 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at CachedDatabase.getPartyIdentifierType (/opt/quoting-service/src/data/database.js:330:36) 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at runMicrotasks (<anonymous>) 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at processTicksAndRejections (internal/process/task_queues.js:97:5) 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at async CachedDatabase.getCacheValue (/opt/quoting-service/src/data/cachedDatabase.js:109:17) 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at async CachedDatabase.createQuoteParty (/opt/quoting-service/src/data/database.js:479:35) 
[dev1-quoting-service-57c765f8-78tsn quoting-service]     at async QuotesModel.handleQuoteRequest (/opt/quoting-service/src/model/quotes.js:292:24) 
[dev1-quoting-service-57c765f8-78tsn quoting-service] (node:26) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 8) 

Severity:
Low

Priority:
Low

Expected Behavior
The POST /quotes should be processed successfully for partySubIdOrType

Steps to Reproduce

  1. send a quote request with partySubIdOrType
curl 'http://dev1-quoting-service/quotes'
  -H 'content-type: application/vnd.interoperability.quotes+json;version=1.0'
  -H 'accept: application/vnd.interoperability.quotes+json;version=1.0'
  -H 'date: Mon, 08 Mar 2021 14:44:32 GMT'
  -H 'fspiop-source: testingtoolkitdfsp'
  -H 'fspiop-destination: payeefsp'
  -H 'traceparent: 00-aabbb5baba213423f84f3ceba11c68ef-0123456789abcdef0-00'
  -H 'user-agent: axios/0.21.1'
  --data-binary '{"quoteId":"db60bb56-eea5-421e-a359-ec26ad1064fb","transactionId":"aa9acc0f-05c3-4651-bc07-b4973826d4bd","payer":{"partyIdInfo":{"partyIdType":"MSISDN","partyIdentifier":"44123456789","fspId":"testingtoolkitdfsp"},"personalInfo":{"complexName":{"firstName":"Firstname-Test","lastName":"Lastname-Test"},"dateOfBirth":"1984-01-01"}},"payee":{"partyIdInfo":{"partyIdType":"MSISDN","partyIdentifier":"27713803912","partySubIdOrType":"30","fspId":"payeefsp"}},"amountType":"RECEIVE","amount":{"amount":"100","currency":"USD"},"transactionType":{"scenario":"TRANSFER","initiator":"PAYER","initiatorType":"CONSUMER"},"note":"test"}'
  --compressed

Specifications

  • Component (if known): quoting-service
  • Version: v12.0.0
  • Platform: AWS / Mojaloop Switch
  • Subsystem: Core services
  • Type of testing: testing tool kit
  • Bug found/raised by: @shashi165

Notes:
This issue is observed for the persistent mode. The pass-through mode will be fine, since it doesn’t involve storing quote request in the database.

Pull Requests:

@shashi165 shashi165 added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Mar 8, 2021
@shashi165 shashi165 added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Mar 8, 2021
@elnyry-sam-k
Copy link
Member

Thanks for logging this @shashi165

@elnyry-sam-k elnyry-sam-k added this to the Sprint 13.4 milestone Mar 15, 2021
@elnyry-sam-k elnyry-sam-k modified the milestones: Sprint 13.4, Sprint 13.5 Mar 26, 2021
@elnyry-sam-k elnyry-sam-k added the triaged This bug has been triaged by the triage team! label Mar 29, 2021
mdebarros added a commit to mojaloop/documentation that referenced this issue Apr 1, 2021
mdebarros added a commit to mojaloop/helm that referenced this issue Apr 1, 2021
1. Maintenance updates to monitoring/efk:
   - Fluentd-elasticsearch dependency chart in monitoring/efk has been deprecated and moved to `https://kokuwaio.github.io/helm-charts`.
   - Updated docs, dependencies for https://kokuwaio.github.io/helm-charts repository
   - Upgraded all monitoring/efk dependencies to latest stable versions
2. Added missing event_* config to ALS Helm chart to ensure that Tracing works by default.
3. Upgraded the following components:
    - Central-Ledger v13.0.1 -> v13.2.5
    - Mojaloop-Simulator v11.3.0 -> v11.4.1
    - SDK-Scheme-Adapter v11.11.2 -> v11.16.0
    - ML-Testing-Toolkit v11.9.4 -> v11.12.0
4. Fixes included:
    - mojaloop/project#2102
    - mojaloop/project#2103
    - mojaloop/project#1962
@elnyry-sam-k elnyry-sam-k removed this from the Sprint 13.5 milestone Apr 14, 2021
@vijayg10 vijayg10 self-assigned this May 3, 2021
@elnyry-sam-k elnyry-sam-k added this to the Sprint 14.1 milestone May 4, 2021
@vijayg10 vijayg10 closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it triaged This bug has been triaged by the triage team!
Projects
None yet
Development

No branches or pull requests

3 participants