feat(db migrations): fix subid db #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijayg10
requested review from
elnyry-sam-k,
lewisdaly,
mdebarros,
oderayi,
shashi165 and
vgenev
as code owners
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The subIdType field in quoteParty table is currently with wrong datatype and also it is referring the partyType field as foreign key which is not as per the specification.
Fix:
Changed the datatype of partySubIdOrTypeId in quoteParty table
Removed the foreignkey reference
Breaking Changes:
The datatype of the subId field in the quoteParty table is changed from integer to string.
So the upgrade should be fine, but when downgrading if a non-integer value of the subId exists in the database then it may break the downgrade process.