feat(mojaloop/project#2553): send extra notification back to payee when a transfer is aborted #872
Conversation
…/2556-patch-notif-on-abort
…/2553-patch-notification-2
There was a problem hiding this comment.
Hey @lewisdaly, this PR is looking good.
No major issues from what I can see, but I do have a "sanity" check that you should consider.
| const eventDetail = { functionality: TransferEventType.NOTIFICATION, action: TransferEventAction.RESERVED_ABORTED } | ||
| const reservedAbortedPayload = { | ||
| transferId: transferAborted.id, | ||
| completedTimestamp: Util.Time.getUTCString(new Date(transferAborted.completedTimestamp)), |
There was a problem hiding this comment.
A good sanity check here is to see what the PayeeFSP would receive when doing a GET /transfers/{ID} request (after the transfer was aborted of course).
There was a problem hiding this comment.
yeah good point - I think I exercise this in the integration tests though - by doing a lookup on the database and ensuring the completed timestamp is the same... let me double check
| @@ -381,22 +381,21 @@ const fulfil = async (error, messages) => { | |||
| const eventDetail = { functionality, action } | |||
| if (action !== TransferEventAction.RESERVE) { | |||
| if (!isTransferError) { | |||
| Logger.isInfoEnabled && Logger.info(Util.breadcrumb(location, `callbackFinilized2--${actionLetter}3`)) | |||
| Logger.isInfoEnabled && Logger.info(Util.breadcrumb(location, `callbackFinalized2--${actionLetter}3`)) | |||
There was a problem hiding this comment.
I may be blind, but I do not see a difference here? :D
| @@ -57,7 +57,7 @@ const migrate = (runMigrations) => { | |||
| } | |||
|
|
|||
| const connectDatabase = async () => { | |||
| Logger.isDebugEnabled && Logger.debug(`Conneting to DB ${JSON.stringify(Config.DATABASE)}`) | |||
| Logger.isDebugEnabled && Logger.debug(`Connecting to DB ${JSON.stringify(Config.DATABASE)}`) | |||
| /** | ||
| * @class TestConsumer | ||
| * @description A Kafka consumer that listens for events from our test harness, and | ||
| * makes it easy to ensure that |
There was a problem hiding this comment.
makes it easy to ensure that....?
| @@ -0,0 +1,163 @@ | |||
| /***** | |||
|
Closing stale PR, and re-created new PR @ #874 |
… scenarios (#874) PR re-based from #872 from @lewisdaly. feat(mojaloop/project/issue2556): Implement patch notification for failure scenarios (following v1.1 update) - mojaloop/project#2556 chore: updated dependencies - updated dependencies - fixed audit issues - fixed lint issues fix([#2697](mojaloop/project#2697)): Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect/non-existent FSP-ID in the FSPIOP-Destination header - mojaloop/project#2697 - fixed/added unit tests - improved test coverage
No description provided.