feat(mojaloop/project#2556): implement patch notification for failure…

… scenarios (#874) PR re-based from #872 from @lewisdaly. feat(mojaloop/project/issue2556): Implement patch notification for failure scenarios (following v1.1 update) - mojaloop/project#2556 chore: updated dependencies - updated dependencies - fixed audit issues - fixed lint issues fix([#2697](mojaloop/project#2697)): Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect/non-existent FSP-ID in the FSPIOP-Destination header - mojaloop/project#2697 - fixed/added unit tests - improved test coverage
mojaloop · Feb 22, 2022 · 8b72cfe · 8b72cfe
1 parent fad85b0
commit 8b72cfe
Show file tree

Hide file tree

Showing 17 changed files with 2,166 additions and 981 deletions.
diff --git a/.ncurc.json b/.ncurc.json
@@ -5,4 +5,3 @@
     "get-port"
   ]
 }
-
diff --git a/README.md b/README.md
@@ -77,7 +77,7 @@ Tests include code coverage via istanbul. See the test/ folder for testing scrip
 If you want to run integration tests in a repetitive manner, you can startup the test containers using `docker-compose`, login to running `central-ledger` container like so:
 
 ```bash
-docker-compose -f docker-compose.yml -f docker-compose.integration.yml up kafka mysql central-ledger
+docker-compose -f docker-compose.yml -f docker-compose.integration.yml up -d kafka mysql central-ledger
 
 #in a new shell
 docker exec -it cl_central-ledger sh

diff --git a/audit-resolve.json b/audit-resolve.json
@@ -1,333 +1,84 @@
 {
   "decisions": {
-    "1589|@mojaloop/object-store-lib>@mojaloop/central-services-logger>rc>ini": {
+    "1006904|hapi-swagger>swagger-ui-dist": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093979764,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-health>@mojaloop/central-services-logger>rc>ini": {
+    "1004946|@mojaloop/event-sdk>@grpc/proto-loader>yargs>string-width>strip-ansi>ansi-regex": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093981212,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-health>@mojaloop/central-services-shared>@mojaloop/central-services-logger>rc>ini": {
+    "1004946|@mojaloop/event-sdk>@grpc/proto-loader>yargs>cliui>string-width>strip-ansi>ansi-regex": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093981212,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-health>@mojaloop/central-services-shared>@mojaloop/event-sdk>@mojaloop/central-services-logger>rc>ini": {
+    "1004946|@mojaloop/event-sdk>@grpc/proto-loader>yargs>cliui>wrap-ansi>string-width>strip-ansi>ansi-regex": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093981212,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-shared>@mojaloop/event-sdk>@mojaloop/central-services-logger>rc>ini": {
+    "1004854|@mojaloop/central-services-shared>widdershins>openapi-sampler>json-pointer": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093982981,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/event-sdk>@mojaloop/central-services-logger>rc>ini": {
+    "1004869|@mojaloop/central-services-shared>widdershins>swagger2openapi>better-ajv-errors>jsonpointer": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093984643,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-logger>rc>ini": {
+    "1004869|@mojaloop/central-services-shared>widdershins>swagger2openapi>oas-validator>better-ajv-errors>jsonpointer": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093984643,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-shared>@mojaloop/central-services-logger>rc>ini": {
+    "1004876|hapi-swagger>swagger-parser>z-schema>validator": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093985740,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-stream>@mojaloop/central-services-logger>rc>ini": {
+    "1004946|@mojaloop/central-services-shared>widdershins>yargs>string-width>strip-ansi>ansi-regex": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093986801,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-health>@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>node-pre-gyp>rc>ini": {
+    "1004946|@mojaloop/central-services-shared>widdershins>yargs>cliui>string-width>strip-ansi>ansi-regex": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093986801,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>node-pre-gyp>rc>ini": {
+    "1005383|@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093987944,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/event-sdk>grpc>node-pre-gyp>rc>ini": {
+    "1005384|@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093987944,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-health>@mojaloop/central-services-shared>@mojaloop/event-sdk>rc>ini": {
+    "1005534|@mojaloop/central-services-shared>widdershins>yargs>yargs-parser": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093989033,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-shared>@mojaloop/event-sdk>rc>ini": {
+    "1006846|@mojaloop/central-services-shared>shins>sanitize-html>postcss": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093990094,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/event-sdk>rc>ini": {
+    "1006886|@mojaloop/central-services-shared>shins>markdown-it": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
+      "madeAt": 1645093991106,
+      "expiresAt": 1647685971147
     },
-    "1589|@mojaloop/central-services-shared>rc>ini": {
+    "1007017|@mojaloop/central-services-shared>widdershins>swagger2openapi>oas-validator>ajv": {
       "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
-    },
-    "1589|rc>ini": {
-      "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
-    },
-    "1589|@mojaloop/central-services-database>knex>liftoff>findup-sync>resolve-dir>global-modules>global-prefix>ini": {
-      "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
-    },
-    "1589|knex>liftoff>findup-sync>resolve-dir>global-modules>global-prefix>ini": {
-      "decision": "ignore",
-      "madeAt": 1609286190947,
-      "expiresAt": 1611878178540
-    },
-    "1500|@mojaloop/central-services-shared>widdershins>yargs>yargs-parser": {
-      "decision": "ignore",
-      "madeAt": 1632909590182,
-      "expiresAt": 1633514382984
-    },
-    "1594|@mojaloop/central-services-health>@mojaloop/central-services-shared>axios": {
-      "decision": "ignore",
-      "madeAt": 1610083790377,
-      "expiresAt": 1612675767235
-    },
-    "1594|@mojaloop/central-services-shared>axios": {
-      "decision": "ignore",
-      "madeAt": 1610083790377,
-      "expiresAt": 1612675767235
-    },
-    "1500|@mojaloop/central-services-health>@mojaloop/central-services-shared>widdershins>yargs>yargs-parser": {
-      "decision": "ignore",
-      "madeAt": 1620636596190,
-      "expiresAt": 1623228560826
-    },
-    "1640|@mojaloop/central-services-health>@mojaloop/central-services-shared>widdershins>urijs": {
-      "decision": "ignore",
-      "madeAt": 1615756855516,
-      "expiresAt": 1618348850367
-    },
-    "1640|@mojaloop/central-services-shared>widdershins>urijs": {
-      "decision": "ignore",
-      "madeAt": 1615756855516,
-      "expiresAt": 1618348850367
-    },
-    "1649|@mojaloop/object-store-lib>mongoose>mquery": {
-      "decision": "ignore",
-      "madeAt": 1620636598642,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-database>knex>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636584445,
-      "expiresAt": 1623228560826
-    },
-    "1677|npm-run-all>read-pkg>normalize-package-data>hosted-git-info": {
-      "decision": "ignore",
-      "madeAt": 1620636590430,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-database>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-health>@mojaloop/central-services-error-handling>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-health>@mojaloop/central-services-shared>@mojaloop/central-services-error-handling>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-health>@mojaloop/central-services-shared>@mojaloop/event-sdk>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-shared>@mojaloop/event-sdk>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/event-sdk>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-health>@mojaloop/central-services-shared>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1673|@mojaloop/central-services-stream>@mojaloop/central-services-error-handling>lodash": {
-      "decision": "ignore",
-      "madeAt": 1620636602940,
-      "expiresAt": 1623228560826
-    },
-    "1675|@mojaloop/central-services-health>@mojaloop/central-services-shared>shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1620636606023,
-      "expiresAt": 1623228560826
-    },
-    "1675|@mojaloop/central-services-shared>shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1632909592635,
-      "expiresAt": 1633514382984
-    },
-    "1676|@mojaloop/central-services-health>@mojaloop/central-services-shared>shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1620636606023,
-      "expiresAt": 1623228560826
-    },
-    "1676|@mojaloop/central-services-shared>shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1632909592635,
-      "expiresAt": 1633514382984
-    },
-    "1693|@mojaloop/central-services-health>@mojaloop/central-services-shared>shins>sanitize-html>postcss": {
-      "decision": "ignore",
-      "madeAt": 1620740704991,
-      "expiresAt": 1621345497277
-    },
-    "1693|@mojaloop/central-services-shared>shins>sanitize-html>postcss": {
-      "decision": "ignore",
-      "madeAt": 1623606403377,
-      "expiresAt": 1626198161510
-    },
-    "1751|require-glob>glob-parent": {
-      "decision": "fix",
-      "madeAt": 1623606347615
-    },
-    "1754|@mojaloop/central-services-shared>shins>cheerio>cheerio-select>css-select>css-what": {
-      "decision": "fix",
-      "madeAt": 1623606387347
-    },
-    "1754|@mojaloop/central-services-shared>shins>cheerio>cheerio-select>css-what": {
-      "decision": "fix",
-      "madeAt": 1623606387347
-    },
-    "1766|@mojaloop/central-services-shared>widdershins>urijs": {
-      "decision": "ignore",
-      "madeAt": 1628186325257,
-      "expiresAt": 1630778312040
-    },
-    "1770|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
-      "decision": "ignore",
-      "madeAt": 1628186340146,
-      "expiresAt": 1630778312040
-    },
-    "1771|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
-      "decision": "ignore",
-      "madeAt": 1628186340146,
-      "expiresAt": 1630778312040
-    },
-    "1779|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
-      "decision": "fix",
-      "madeAt": 1631789411221
-    },
-    "1780|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
-      "decision": "fix",
-      "madeAt": 1631789411221
-    },
-    "1781|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
-      "decision": "fix",
-      "madeAt": 1631789411221
-    },
-    "1785|@mojaloop/object-store-lib>mongoose>mpath": {
-      "decision": "ignore",
-      "madeAt": 1632909595878,
-      "expiresAt": 1633514382984
-    },
-    "1002401|@mojaloop/event-sdk>@grpc/proto-loader>yargs>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1636383357793,
-      "expiresAt": 1638975351187
-    },
-    "1002401|@mojaloop/event-sdk>@grpc/proto-loader>yargs>cliui>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1636383357794,
-      "expiresAt": 1638975351187
-    },
-    "1002401|@mojaloop/event-sdk>@grpc/proto-loader>yargs>cliui>wrap-ansi>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1636383357794,
-      "expiresAt": 1638975351187
-    },
-    "1002401|blipp>easy-table>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1636383359018,
-      "expiresAt": 1638975351187
-    },
-    "1002423|@mojaloop/central-services-shared>shins>cheerio>cheerio-select>css-select>nth-check": {
-      "decision": "ignore",
-      "madeAt": 1636383360126,
-      "expiresAt": 1638975351187
-    },
-    "1002401|@mojaloop/central-services-shared>widdershins>yargs>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1636383361373,
-      "expiresAt": 1638975351187
-    },
-    "1002401|@mojaloop/central-services-shared>widdershins>yargs>cliui>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1636383361373,
-      "expiresAt": 1638975351187
-    },
-    "1002490|@mojaloop/object-store-lib>mongoose>mpath": {
-      "decision": "ignore",
-      "madeAt": 1636383362665,
-      "expiresAt": 1638975351187
-    },
-    "1002865|@mojaloop/central-services-shared>shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1636383364395,
-      "expiresAt": 1638975351187
-    },
-    "1002866|@mojaloop/central-services-shared>shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1636383364395,
-      "expiresAt": 1638975351187
-    },
-    "1003019|@mojaloop/central-services-shared>widdershins>yargs>yargs-parser": {
-      "decision": "ignore",
-      "madeAt": 1636383365881,
-      "expiresAt": 1638975351187
-    },
-    "1004784|hapi-swagger>swagger-parser>z-schema>validator": {
-      "decision": "ignore",
-      "madeAt": 1636383367449,
-      "expiresAt": 1638975351187
-    },
-    "1004809|@mojaloop/central-services-shared>widdershins>openapi-sampler>json-pointer": {
-      "decision": "ignore",
-      "madeAt": 1636447959947,
-      "expiresAt": 1639039953006
-    },
-    "1004812|@mojaloop/central-services-shared>widdershins>swagger2openapi>better-ajv-errors>jsonpointer": {
-      "decision": "ignore",
-      "madeAt": 1636447961306,
-      "expiresAt": 1639039953006
-    },
-    "1004812|@mojaloop/central-services-shared>widdershins>swagger2openapi>oas-validator>better-ajv-errors>jsonpointer": {
-      "decision": "ignore",
-      "madeAt": 1636447961306,
-      "expiresAt": 1639039953006
+      "madeAt": 1645093992120,
+      "expiresAt": 1647685971147
     }
   },
   "rules": {},