Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after unloading extension. #3226

Merged
merged 6 commits into from
Jul 15, 2023
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions cogs/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,17 @@ async def load_plugin(self, plugin):
logger.error("Plugin load failure: %s", plugin.ext_string, exc_info=True)
raise InvalidPluginError("Cannot load extension, plugin invalid.") from exc

async def unload_plugin(self, plugin: Plugin) -> None:
try:
await self.bot.unload_extension(plugin.ext_string)
except commands.ExtensionError as exc:
raise exc

ext_parent = ".".join(plugin.ext_string.split(".")[:-1])
for module in list(sys.modules.keys()):
if module == ext_parent or module.startswith(ext_parent + "."):
del sys.modules[module]

async def parse_user_input(self, ctx, plugin_name, check_version=False):

if not self.bot.config["enable_plugins"]:
Expand Down Expand Up @@ -378,7 +389,7 @@ async def plugins_add(self, ctx, *, plugin_name: str):
logger.warning("Unable to download plugin %s.", plugin, exc_info=True)

embed = discord.Embed(
description=f"Failed to download plugin, check logs for error.\n{type(e)}: {e}",
description=f"Failed to download plugin, check logs for error.\n{type(e).__name__}: {e}",
color=self.bot.error_color,
)

Expand All @@ -397,7 +408,7 @@ async def plugins_add(self, ctx, *, plugin_name: str):
logger.warning("Unable to load plugin %s.", plugin, exc_info=True)

embed = discord.Embed(
description=f"Failed to download plugin, check logs for error.\n{type(e)}: {e}",
description=f"Failed to load plugin, check logs for error.\n{type(e).__name__}: {e}",
color=self.bot.error_color,
)

Expand Down Expand Up @@ -438,7 +449,7 @@ async def plugins_remove(self, ctx, *, plugin_name: str):

if self.bot.config.get("enable_plugins"):
try:
await self.bot.unload_extension(plugin.ext_string)
await self.unload_plugin(plugin)
self.loaded_plugins.remove(plugin)
except (commands.ExtensionNotLoaded, KeyError):
logger.warning("Plugin was never loaded.")
Expand Down Expand Up @@ -480,9 +491,10 @@ async def update_plugin(self, ctx, plugin_name):
await self.download_plugin(plugin, force=True)
if self.bot.config.get("enable_plugins"):
try:
await self.bot.unload_extension(plugin.ext_string)
await self.unload_plugin(plugin)
except commands.ExtensionError:
logger.warning("Plugin unload fail.", exc_info=True)

try:
await self.load_plugin(plugin)
except Exception:
Expand Down Expand Up @@ -529,17 +541,20 @@ async def plugins_reset(self, ctx):
for ext in list(self.bot.extensions):
if not ext.startswith("plugins."):
continue
logger.error("Unloading plugin: %s.", ext)
try:
logger.error("Unloading plugin: %s.", ext)
await self.bot.unload_extension(ext)
except Exception:
logger.error("Failed to unload plugin: %s.", ext)
else:
if not self.loaded_plugins:
continue
plugin = next((p for p in self.loaded_plugins if p.ext_string == ext), None)
if plugin:
await self.unload_plugin(plugin)
self.loaded_plugins.remove(plugin)
else:
await self.bot.unload_extension(ext)
Taaku18 marked this conversation as resolved.
Show resolved Hide resolved
except Exception:
logger.error("Failed to unload plugin: %s.", ext)

for module in list(sys.modules.keys()):
if module.startswith("plugins."):
del sys.modules[module]

self.bot.config["plugins"].clear()
await self.bot.config.update()
Expand Down