-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup after unloading extension. #3226
Conversation
Is this necessary? Deleting from |
I'm not sure about the issue this will cause. But
For QOL improvements, I think this is necessary. I also read on dpy server (a while ago before creating this PR) when someone asked about the flexibility of removing modules when unloading extensions, Danny said it should be handled by developers (not library). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except one minor issue. Once that issue comment gets resolved, we can proceed with the merge. :)
* Cleanup after unloading extension, resolve modmail-dev#3223. * Remove leftover modules loaded from `plugins` path when purging. --------- Co-authored-by: Taku <[email protected]>
* Cleanup after unloading extension, resolve modmail-dev#3223. * Remove leftover modules loaded from `plugins` path when purging. --------- Co-authored-by: Taku <[email protected]> (cherry picked from commit a784f82) Signed-off-by: Khakers <[email protected]>
* Cleanup after unloading extension, resolve modmail-dev#3223. * Remove leftover modules loaded from `plugins` path when purging. --------- Co-authored-by: Taku <[email protected]> (cherry picked from commit a784f82) Signed-off-by: Khakers <[email protected]>
This resolves #3223.
?plugin remove ...
or?plugin update ...
command.Generally, this is not a breaking change. Existing plugins would still work just fine.
Reference:
commands/ext/bot.py
L911-L927