Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#6653: value_counts(): Eliminate redundant sorting. #6654

Merged
merged 2 commits into from
Oct 17, 2023
Merged

PERF-#6653: value_counts(): Eliminate redundant sorting. #6654

merged 2 commits into from
Oct 17, 2023

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves PERF: value_counts(): Eliminate redundant sorting. #6653
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko AndreyPavlenko requested a review from a team as a code owner October 16, 2023 18:54
anmyachev
anmyachev previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dchigarev
dchigarev previously approved these changes Oct 17, 2023
View reviewed changes
@dchigarev dchigarev self-requested a review October 17, 2023 08:32
dchigarev
dchigarev reviewed Oct 17, 2023
View reviewed changes
modin/pandas/base.py Outdated Show resolved Hide resolved
@AndreyPavlenko @dchigarev
Update modin/pandas/base.py
adbf8f3 
Co-authored-by: Dmitry Chigarev <[email protected]>
@AndreyPavlenko AndreyPavlenko dismissed stale reviews from dchigarev and anmyachev via adbf8f3 October 17, 2023 11:17
@anmyachev anmyachev merged commit 9c03202 into modin-project:master Oct 17, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

@anmyachev anmyachev anmyachev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERF: value_counts(): Eliminate redundant sorting.
3 participants
@AndreyPavlenko @anmyachev @dchigarev