Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: value_counts(): Eliminate redundant sorting. #6653

Closed
AndreyPavlenko opened this issue Oct 16, 2023 · 0 comments · Fixed by #6654
Closed

PERF: value_counts(): Eliminate redundant sorting. #6653

AndreyPavlenko opened this issue Oct 16, 2023 · 0 comments · Fixed by #6654
Labels
Performance 🚀 Performance related issues and pull requests.

Comments

@AndreyPavlenko
Copy link
Collaborator

The value_counts() implementation calls groupby() without the sort argument, which defaults to True - https://github.com/modin-project/modin/blob/master/modin/pandas/base.py#L3633 . This sorting is redundant here.
@AndreyPavlenko AndreyPavlenko added the Performance 🚀 Performance related issues and pull requests. label Oct 16, 2023
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Oct 16, 2023
@AndreyPavlenko
PERF-modin-project#6653: value_counts(): Eliminate redundant sorting.
92934c1 
Signed-off-by: Andrey Pavlenko <[email protected]>
@AndreyPavlenko AndreyPavlenko mentioned this issue Oct 16, 2023
Merged
7 tasks
anmyachev pushed a commit that referenced this issue Oct 17, 2023
@AndreyPavlenko @dchigarev
PERF-#6653: value_counts(): Eliminate redundant sorting. (#6654)
9c03202 
Signed-off-by: Andrey Pavlenko <[email protected]>
Co-authored-by: Dmitry Chigarev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PERF-#6653: value_counts(): Eliminate redundant sorting. AndreyPavlenko/modin
1 participant
@AndreyPavlenko