Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#6583: Remove redundant index reassignment in query() #6584

Merged
merged 2 commits into from
Sep 19, 2023
Merged

PERF-#6583: Remove redundant index reassignment in query() #6584

merged 2 commits into from
Sep 19, 2023

Conversation

mvashishtha
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves PERF: Remove redundant index reassignment in query() with one-level index #6583
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@mvashishtha mvashishtha marked this pull request as ready for review September 18, 2023 21:34
@mvashishtha mvashishtha requested a review from a team as a code owner September 18, 2023 21:34
RehanSD
RehanSD previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fix BaseOnPython tests
6a26413 
Signed-off-by: mvashishtha <[email protected]>
RehanSD
RehanSD approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RehanSD RehanSD merged commit e5102f5 into modin-project:master Sep 19, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSD RehanSD RehanSD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERF: Remove redundant index reassignment in query() with one-level index
2 participants
@mvashishtha @RehanSD