Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Remove redundant index reassignment in query() with one-level index #6583

Closed
mvashishtha opened this issue Sep 18, 2023 · 0 comments · Fixed by #6584
Closed

PERF: Remove redundant index reassignment in query() with one-level index #6583

mvashishtha opened this issue Sep 18, 2023 · 0 comments · Fixed by #6584
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.

Comments

@mvashishtha
Copy link
Collaborator

this assignment is redundant for a one-level index: https://github.com/pandas-dev/pandas/blob/68268458ae3091875841b750c9763e64de835e2f/pandas/core/generic.py#L596

Modin on pandas storage format has to copy the index metadata to the partitions.

I don't want to try contributing this change to pandas because pandas copies the index by reference and there's no performance penalty that I know of.
@mvashishtha mvashishtha added Performance 🚀 Performance related issues and pull requests. P2 Minor bugs or low-priority feature requests labels Sep 18, 2023
mvashishtha pushed a commit to mvashishtha/modin that referenced this issue Sep 18, 2023
PERF-modin-project#6583: Remove redundant index reassignment in query()
931fb46 
Signed-off-by: mvashishtha <[email protected]>
@mvashishtha mvashishtha mentioned this issue Sep 18, 2023
Merged
7 tasks
RehanSD pushed a commit that referenced this issue Sep 19, 2023
@mvashishtha
PERF-#6583: Remove redundant index reassignment in query() (#6584)
e5102f5 
Signed-off-by: mvashishtha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PERF-#6583: Remove redundant index reassignment in query() mvashishtha/modin
1 participant
@mvashishtha