TEST-#1779: Limit object store to 1GB during CI tests #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnlitvinov
added
Code Quality 💯
Codecov Report
@@ Coverage Diff @@
## master #1744 +/- ##
==========================================
+ Coverage 82.98% 84.27% +1.29%
==========================================
Files 77 77
Lines 8282 8282
==========================================
+ Hits 6873 6980 +107
+ Misses 1409 1302 -107
Continue to review full report at Codecov.
|
|
|
|
|
@vnlitvinov You will need to rebase off the master to rerun tests |
vnlitvinov
force-pushed
the
hunting-broken-ray
branch
from
4b9495e to
75d47d2
Compare
anmyachev
requested changes
Jul 18, 2020
|
@vnlitvinov could you please also create a issue? |
vnlitvinov
force-pushed
the
hunting-broken-ray
branch
from
75d47d2 to
ae2101f
Compare
vnlitvinov
changed the title
vnlitvinov
changed the title
|
@anmyachev I believe I've addressed your comments. |
vnlitvinov
force-pushed
the
hunting-broken-ray
branch
from
ae2101f to
4701038
Compare
devin-petersohn
requested changes
Jul 23, 2020
There was a problem hiding this comment.
@vnlitvinov Please update the commit tag to TEST. Looks great otherwise!
vnlitvinov
force-pushed
the
hunting-broken-ray
branch
2 times, most recently
from
e6414e6 to
5c48521
Compare
vnlitvinov
changed the title
vnlitvinov
force-pushed
the
hunting-broken-ray
branch
from
5c48521 to
070a779
Compare
Signed-off-by: Vasilij Litvinov <[email protected]>
vnlitvinov
force-pushed
the
hunting-broken-ray
branch
from
070a779 to
70b1b59
Compare
|
@devin-petersohn tests are finally green here, this could be merged if no objections. |
devin-petersohn
approved these changes
Jul 26, 2020
devin-petersohn
changed the title
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…odin-project#1744) Signed-off-by: Vasilij Litvinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasilij Litvinov [email protected]
What do these changes do?
This should (hopefully) fix Ray testing on Windows in CI and after pushes to master, as they currently turned red.
Tests start to run locally on my laptop after this change (and they didn't prior to it because Ray was told to allocate 20 GB of storage (out of my 32 GB of RAM) but my guess is Ray tried to allocate those on my disk which has less free space than 20 GB).
flake8 modinblack --check modingit commit -s