-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: eval_general should assume by default that pandas does not throw an error #6016
Comments
@mvashishtha I agree, we should change the default behaviour. |
+1 on this change |
I would add that we may want to check that error messages are "close" (I don't have a good enough definition of "close" here, though). The case my proposal is aimed at is handling a case when e.g. pandas throws an |
…ptions by default Signed-off-by: Anatoly Myachev <[email protected]>
…ptions by default Signed-off-by: Anatoly Myachev <[email protected]>
…ptions by default Signed-off-by: Anatoly Myachev <[email protected]>
…ptions by default Signed-off-by: Anatoly Myachev <[email protected]>
…ault (#6954) Signed-off-by: Anatoly Myachev <[email protected]>
right now
eval_general
with default parameters will not raise an assertion if both pandas and modin raise an error, even if that error is due to a mistake in writing the test code. This is dangerous behavior and it has silently swallowed mistakes in test code before. We should have to explicitly state that we are looking for an error.Right now it's possible to work around this by setting
raising_exceptions=(Exception,)
, but that should be the default.@modin-project/modin-contributors @modin-project/modin-core @anmyachev I would like your thoughts on this.
The text was updated successfully, but these errors were encountered: