Skip to content

Commit

Permalink
TEST-modin-project#6016: make sure 'eval_general' doesn't expect exce…
Browse files Browse the repository at this point in the history
…ptions by default

Signed-off-by: Anatoly Myachev <[email protected]>
  • Loading branch information
anmyachev committed Mar 1, 2024
1 parent 2e5aba1 commit 1bcb09e
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 15 deletions.
2 changes: 0 additions & 2 deletions modin/pandas/test/dataframe/test_map_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,6 @@ def test_astype_int64_to_astype_category_github_issue_6259():
index=["a", "b", "c", "d", "e"],
),
lambda df: df["c0"].astype("Int64").astype("category"),
# work around https://github.com/modin-project/modin/issues/6016
raising_exceptions=(Exception,),
)


Expand Down
6 changes: 0 additions & 6 deletions modin/pandas/test/dataframe/test_udf.py
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,6 @@ def test_query_named_index():
eval_general(
*(df.set_index("col1") for df in create_test_dfs(test_data["int_data"])),
lambda df: df.query("col1 % 2 == 0 | col3 % 2 == 1"),
# work around https://github.com/modin-project/modin/issues/6016
raising_exceptions=(Exception,),
)


Expand All @@ -462,8 +460,6 @@ def test_query_named_multiindex():
for df in create_test_dfs(test_data["int_data"])
),
lambda df: df.query("col1 % 2 == 1 | col3 % 2 == 1"),
# work around https://github.com/modin-project/modin/issues/6016
raising_exceptions=(Exception,),
)


Expand All @@ -476,8 +472,6 @@ def make_df(without_index):
eval_general(
*(make_df(df) for df in create_test_dfs(test_data["int_data"])),
lambda df: df.query("ilevel_0 % 2 == 0 | ilevel_1 % 2 == 1 | col4 % 2 == 1"),
# work around https://github.com/modin-project/modin/issues/6016
raising_exceptions=(Exception,),
)


Expand Down
3 changes: 0 additions & 3 deletions modin/pandas/test/test_groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,6 @@ def test_groupby_agg_with_empty_column_partition_6175(method):
df,
df._to_pandas(),
lambda df: getattr(df.groupby(["col33", "index"]), method)(),
# work around https://github.com/modin-project/modin/issues/6016: we don't
# expect any exceptions.
raising_exceptions=(Exception,),
)


Expand Down
3 changes: 0 additions & 3 deletions modin/pandas/test/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -3200,9 +3200,6 @@ def test_to_dict_series(kwargs):
eval_general(
*[df.iloc[:, 0] for df in create_test_dfs(utils_test_data["int_data"])],
lambda df: df.to_dict(**kwargs),
# TODO(https://github.com/modin-project/modin/issues/6016): fix eval_general
# and remove this raising_exceptions
raising_exceptions=(Exception,),
)


Expand Down
2 changes: 1 addition & 1 deletion modin/pandas/test/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ def eval_general(
comparator=df_equals,
__inplace__=False,
check_exception_type=True,
raising_exceptions=None,
raising_exceptions=(Exception,),
check_kwargs_callable=True,
md_extra_kwargs=None,
comparator_kwargs=None,
Expand Down

0 comments on commit 1bcb09e

Please sign in to comment.