-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs in mtlkt.py #402
Comments
Thanks @gdefilippis, we are taking a look. |
@gdefilippis thanks for bringing this to our attention. I'm going to work
on putting together a multi-species test problem with LKT. If you have a
small example already put together that builds the model from scratch, and
wouldn't mind sharing, I will incorporate that instead.
Thanks, Eric
…On Mon, Oct 1, 2018 at 11:15 AM gdefilippis ***@***.***> wrote:
1. Lines 167 - 174 should be replaced by:
self.coldlak = [Util2d(model, (nlkinit,), np.float32, coldlak,
name='coldlak', locat=self.unit_number[0],
array_free_format=False)]
This is because you would get an error at line 190, saying that the method
append cannot be used if self.coldlak is an Util2d object instead of a list.
1. Line 227 should be replaced by:
for coldlak in self.coldlak:
f_lkt.write(coldlak.get_file_entry())
This is because in the .lkt file you would get coldlak values for the
first species only
1. Line 446 should be replaced by:
for icomp in range(1, ncomp):
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#402>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADFi4AvVR_vlmgEuFfL9ZaXI_Gedt8azks5uglu6gaJpZM4XCnN9>
.
|
I have a model I used to integrate the LKT package in the QGIS-based FREEWAT interface (www.freewat.eu), which uses flopy for writing codes input files. Thank you, |
…e lakes (#412) * Explicit cast to np.array isn't preserved * Fixes issue in LAK package _init_ routines when only a single lake is active * Previous alteration worked for one lake, but didn't handle one stage for multiple lakes. This should account for that condition * Fix mis-statement * LMT: Lacking support for keyword 'ALL' following Package_Flows keyword * Add precision for variable thkmin * PERLEN variable getting trucated by use of "G" (general form) when number of significant digits was > 4. * Switching printing of PERLEN in BTN from 10.6G to 10G * Fix for issue #402 including a new test for checking mtlkt.py * Remove apostrophe from comment (interferes with Travis build) * Rename test, another recent commit had the same name * Remove argument from call to test
@gdefilippis If you pull the latest changes on the develop branch, your problem should be working with the changes made under pull request #412 Thanks for your patience. Let us know if something doesn't look quite right. |
* Explicit cast to np.array isn't preserved * Fixes issue in LAK package _init_ routines when only a single lake is active * Previous alteration worked for one lake, but didn't handle one stage for multiple lakes. This should account for that condition * Fix mis-statement * LMT: Lacking support for keyword 'ALL' following Package_Flows keyword * Add precision for variable thkmin * PERLEN variable getting trucated by use of "G" (general form) when number of significant digits was > 4. * Switching printing of PERLEN in BTN from 10.6G to 10G * Fix for issue #402 including a new test for checking mtlkt.py * Remove apostrophe from comment (interferes with Travis build) * Rename test, another recent commit had the same name * Remove argument from call to test * Adding new example notebook for MT3D-USGS that uses SFT, LKT, and UZT, including connections between them * Fixed a typo, added link for docs/notebook_examples.md in a reasonable section of the document * An errant capital letter in the new notebook, switched to lowercase
#414) * update(ModflowFlwob and ModflowHob): added "no_print", "options", and "filenames" kwargs. * refactor(modpath): refactor MODPATH 7 particle classes Refactor MODPATH 7 particle classes to make a clear distinction between particle groups and particle data (locations, etc.). * Changes to LKT for dealing with multi-species simulations that include lakes (#412) * Explicit cast to np.array isn't preserved * Fixes issue in LAK package _init_ routines when only a single lake is active * Previous alteration worked for one lake, but didn't handle one stage for multiple lakes. This should account for that condition * Fix mis-statement * LMT: Lacking support for keyword 'ALL' following Package_Flows keyword * Add precision for variable thkmin * PERLEN variable getting trucated by use of "G" (general form) when number of significant digits was > 4. * Switching printing of PERLEN in BTN from 10.6G to 10G * Fix for issue #402 including a new test for checking mtlkt.py * Remove apostrophe from comment (interferes with Travis build) * Rename test, another recent commit had the same name * Remove argument from call to test * refactor(modpath): refactor particledata (#416) Refactor ParticleData (input style 1) so that it is the same as the node template (input style 3). Refactor NodeParticleTemplates particles into a single class. Add starting particle location data input style 2. * New jupyter notebook for MT3D-USGS (#415) * Explicit cast to np.array isn't preserved * Fixes issue in LAK package _init_ routines when only a single lake is active * Previous alteration worked for one lake, but didn't handle one stage for multiple lakes. This should account for that condition * Fix mis-statement * LMT: Lacking support for keyword 'ALL' following Package_Flows keyword * Add precision for variable thkmin * PERLEN variable getting trucated by use of "G" (general form) when number of significant digits was > 4. * Switching printing of PERLEN in BTN from 10.6G to 10G * Fix for issue #402 including a new test for checking mtlkt.py * Remove apostrophe from comment (interferes with Travis build) * Rename test, another recent commit had the same name * Remove argument from call to test * Adding new example notebook for MT3D-USGS that uses SFT, LKT, and UZT, including connections between them * Fixed a typo, added link for docs/notebook_examples.md in a reasonable section of the document * An errant capital letter in the new notebook, switched to lowercase * docs: update documentation (#417) Update docstrings for MFGridFile class. Update README.md and CONTRIBUTING.md. Update pre-commit.py to use develop branch for branches with "-" or ":" in the branch name (it is assumed these are bug fix or feature branches for the develop branch. * refactor(lgrutil.py) : redesign of the hidden lgrutil gem Unfortunately, this breaks backward compatibility (if anyone was using this). But the new implementation should be a little easier to use. Still need to implement ghost nodes. * Removed old newline character before "NOPRINT". * docs: update docstrings (#418) Update docstrings for HeadObservation, ModflowHobs, and ModflowFlwob classes. Closed #406 * docs: update docstrings (#419) Update docstrings for sphinx. * refactor(Modflow): Forgive loading models with an incomplete BAS6 package (#420) * raise IOError if external file does not exist * remove requirement that BAS6 needs to be loaded in full * update(ModflowFlwob and ModflowHob): add condition test to check for user-specified output file names. * update(ModflowFlwob and ModflowHob): reworked additional code again after refactorization of upstream branch. * update(ModflowFlwob and ModflowHob): reordered kwargs in __init__ to reflect order in docstring. * update(ModflowFlwob and ModflowHob): reworked additional code again after refactorization of upstream branch. * update(ModflowFlwob and ModflowHob): pass list of filenames to Package.__init__() to achieve desired output file names. * update(ModflowFlwob and ModflowHob): updated HOB test and added new code to test FLWOBS. * update(ModflowFlwob and ModflowHob): pass mf executable name to new model upon load.
@emorway-usgs should this issue be closed? |
* Explicit cast to np.array isn't preserved * Fixes issue in LAK package _init_ routines when only a single lake is active * Previous alteration worked for one lake, but didn't handle one stage for multiple lakes. This should account for that condition * Fix mis-statement * LMT: Lacking support for keyword 'ALL' following Package_Flows keyword * Add precision for variable thkmin * PERLEN variable getting trucated by use of "G" (general form) when number of significant digits was > 4. * Switching printing of PERLEN in BTN from 10.6G to 10G * Fix for issue #402 including a new test for checking mtlkt.py * Remove apostrophe from comment (interferes with Travis build) * Rename test, another recent commit had the same name * Remove argument from call to test * Adding new example notebook for MT3D-USGS that uses SFT, LKT, and UZT, including connections between them * Fixed a typo, added link for docs/notebook_examples.md in a reasonable section of the document * An errant capital letter in the new notebook, switched to lowercase * Removing variable MXUZCON from mtuzt.py. Variable was in pre-release versions of MT3D-USGS, but didn't make the final cut and was never removed from flopy until now. Fixes and closes issue #423 * Indexes needed adjusting after removing un-used variable from Item 2 in UZT input file. * Fixing another index issue brought about by the removal of MXUZCON
Dear all, |
* Explicit cast to np.array isn't preserved * Fixes issue in LAK package _init_ routines when only a single lake is active * Previous alteration worked for one lake, but didn't handle one stage for multiple lakes. This should account for that condition * Fix mis-statement * LMT: Lacking support for keyword 'ALL' following Package_Flows keyword * Add precision for variable thkmin * PERLEN variable getting trucated by use of "G" (general form) when number of significant digits was > 4. * Switching printing of PERLEN in BTN from 10.6G to 10G * Fix for issue #402 including a new test for checking mtlkt.py * Remove apostrophe from comment (interferes with Travis build) * Rename test, another recent commit had the same name * Remove argument from call to test * Adding new example notebook for MT3D-USGS that uses SFT, LKT, and UZT, including connections between them * Fixed a typo, added link for docs/notebook_examples.md in a reasonable section of the document * An errant capital letter in the new notebook, switched to lowercase * Removing variable MXUZCON from mtuzt.py. Variable was in pre-release versions of MT3D-USGS, but didn't make the final cut and was never removed from flopy until now. Fixes and closes issue #423 * Indexes needed adjusting after removing un-used variable from Item 2 in UZT input file. * Fixing another index issue brought about by the removal of MXUZCON * test(t012_test.py): Account for UZT -> UZT2 input file changes With the release of MT3D-USGS 1.0.1, required UZT input was reduced #466 and #482 * test(t012_test.py): Adapt flopy src to new UZT2 input requirements These changes required witth the release of MT3D-USGS 1.0.1 #466 and #482 * docs(releasenotes): update releasenotes with UZT2 fix
This is because you would get an error at line 190, saying that the method append cannot be used if self.coldlak is an Util2d object instead of a list.
This is because in the .lkt file you would get coldlak values for the first species only
The text was updated successfully, but these errors were encountered: