Integrate dprint to enable no-mixed-operators in eslint
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is not necessary to reproduce prettier's behavior if we use dprint. I like default configuration. If possible, I don't want to see any configuration files at all. I like zero config. If we choice dprint, let's use it without any configuration. minimal. |
dprint/dprint#413 exists. However I think choosing dprint means to need some config because of the configurable tool direction as we use eslint config. |
|
Thanks for your approval! |
kachick
added a commit
to pankona/hashira
that referenced
this pull request
Jun 21, 2023
ref: #866, #869 This configuration is not my preference. It keeps zero configration as possible we can. Because I respect the pankona wish as he said as mobu-of-the-world/mobu#489 (comment). --- Ignore files around gitbook Because some of them are generated by tools. And we may drop gitbook dependency. See #870
|
FYI: Microsoft is now using dprint for their TypeScript repository microsoft/TypeScript#54820 |
Completely replaced in #1487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dprint vs prettier
Both have the strongness. Prettier has strong opinion and huge community, and looks stable behavior in these days.
dprint is pluggable, configurable and super fast ⚡.
Why dprint now?
Because prettier does not provide some options with their opinion.
A most negative to me is prettier/prettier#187.
I strongly agree eslint rule no-mixed-operators.
At least, added parenthesis should not be removed by formatter if it was coder wanted.
However no option exists when using prettier.
It is a blocker to me especially developing around timer logics as #486.
Dprint is frequently developing now. So some style can't be adjusted to prettier does well.
But I 👍 for their decisions and I think it is enough ready to be used.
How
This PR does not perfectly drop prettier, it still used in HTML, CSS and YAML. Dprint runs on TypeScript, JavaScript, JSON, Markdown.
And needed to enable renovate to upgrade their plugins.
Configure
Some choice exists, however I have chosen minimum one.
If you strongly want enable some options, look at https://dprint.dev/config/ and https://dprint.dev/plugins/typescript/.
I can't reproduce 100% prettier behaviors even I have tried with some options in few hours.
Refs
🇯🇵