Prefer calculation from actual time rather than increment set*
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankona
reviewed
Jul 1, 2022
kachick
added a commit
that referenced
this pull request
Jul 1, 2022
#486 (comment) This PR partially invert #476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484
I have avoided worker based solutions as written as #484 (comment).
The choice is actual duration based, I guess it
reducesthe differences even in background tabs. (Should not be perfect.)https://stackoverflow.com/a/5927432/1212807
I hope background tasks should not take high power. So I hope this resolves the issues...
@pankona Could you review? (I didn't check long time run.)