Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds all files necessary for GoIconButtonComponent #57

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Adds all files necessary for GoIconButtonComponent #57

merged 4 commits into from
Jul 23, 2019

Conversation

jaredami
Copy link
Contributor

@jaredami jaredami commented Jul 10, 2019 •
edited
Loading

Creates a component for buttons with icons that do not have text.

Implementation example:

<go-icon-button buttonIcon="home" (handleClick)="openThing()"></go-icon-button>

@grahamhency - review everything

@jaredami jaredami added the chore General chore or maintenance task label Jul 10, 2019
@AlexOverbeck AlexOverbeck added this to the V1.1.0 milestone Jul 11, 2019
grahamhency
grahamhency suggested changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great! Just a few stylistic and formatting comments, I'd also maybe throw a screenshot up in the description just so we can document what the initial button looks like. Nice work!

@jaredami jaredami requested a review from grahamhency July 19, 2019 19:52
grahamhency
grahamhency reviewed Jul 22, 2019
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just two comments here. Once those are address, I'm good to 👍 this guy.

@jaredami jaredami requested a review from grahamhency July 22, 2019 17:50
grahamhency
grahamhency approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! We can follow up and convert all other instances of this in the rest of the components.

@jaredami jaredami merged commit 15984d9 into v1.1.0 Jul 23, 2019
@grahamhency grahamhency deleted the go_icon_button branch July 23, 2019 17:20
AlexOverbeck pushed a commit that referenced this pull request Jul 24, 2019
@jaredami @AlexOverbeck
Adds all files necessary for GoIconButtonComponent (#57)
2102797 
* Adds all files necessary for GoIconButtonComponent

Creates a component for button with icons with no text.
AlexOverbeck added a commit that referenced this pull request Jul 30, 2019
@AlexOverbeck
V1.1.0 (#92)
52ffdc4 
* Adds Side Navigation Module

* Bugfix for empty table column Fixes #53

* Feature Go Search

* Code review revisions

* Adds all files necessary for GoIconButtonComponent (#57)

* Adds all files necessary for GoIconButtonComponent

Creates a component for button with icons with no text.

* Add title attribute to go-icon-button

* Init commit of go-layout

* Added header

* Added go-side-nav to go-layout

* Clean up disjointed rebase

* Rebase style issues with go-icon-button

* Formatting fixes

* Fix failing component creation tests

* Fix a rebase

* Updated menu icon to go-icon-button

* Updates to search animations

Fixes animation errors in firefox

* Add map for z-indexes

* Fix where z-index is applied for search and off-canvas

* Fixes issue with loader svg in Safari. Closes #82 (#93)

* Fixes issue with loader svg in Safari. Closes #82

There was an issue in the Safari browser where the loading svg
would look like three black circles. This was a result of there
being duplicate IDs within the svgs markup.

Generating unique IDs and applying the fill to the paths inline
based on those unique IDs fixes this problem.

* Implements new version of the loading svg

The previous version of the loading svg had some issues in specific
browsers becuase it was reliant on gradient filters. This redesigns
the svg to no longer use gradients and uses angular to do some of
the animations on the host element.

* Adds tests for go-loader component

* Updates go-tester to test loader

* Add boolean to @HostBinding animation

* Bug ie edge cases (#91)

* Fixes IE and Edge bugs with components for v1.1

* Removes 'x' on search input

* Fix title attr and center alignment

* Implemented styles and functionality for a mobile layout (#94)

* [Feature] Go-Action-Sheet (#90)

* Added the ability to provide actions on a table in a toolbar at the top (#97)

* Renames title to panelContent to avoid conflicts with native functionality (#98)

We had an issue with the <go-panel> component where the title @input
was exposing things we didn't want it to because of its naming
collision with the native title attribute. Updating the name of said
attribute to panelContent fixes this issue.
AlexOverbeck added a commit that referenced this pull request Jul 30, 2019
@AlexOverbeck
V1.1.0 (#102)
d89f588 
* Adds Side Navigation Module

* Bugfix for empty table column Fixes #53

* Feature Go Search

* Code review revisions

* Adds all files necessary for GoIconButtonComponent (#57)

* Adds all files necessary for GoIconButtonComponent

Creates a component for button with icons with no text.

* Add title attribute to go-icon-button

* Init commit of go-layout

* Added header

* Added go-side-nav to go-layout

* Clean up disjointed rebase

* Rebase style issues with go-icon-button

* Formatting fixes

* Fix failing component creation tests

* Fix a rebase

* Updated menu icon to go-icon-button

* Updates to search animations

Fixes animation errors in firefox

* Add map for z-indexes

* Fix where z-index is applied for search and off-canvas

* Fixes issue with loader svg in Safari. Closes #82 (#93)

* Fixes issue with loader svg in Safari. Closes #82

There was an issue in the Safari browser where the loading svg
would look like three black circles. This was a result of there
being duplicate IDs within the svgs markup.

Generating unique IDs and applying the fill to the paths inline
based on those unique IDs fixes this problem.

* Implements new version of the loading svg

The previous version of the loading svg had some issues in specific
browsers becuase it was reliant on gradient filters. This redesigns
the svg to no longer use gradients and uses angular to do some of
the animations on the host element.

* Adds tests for go-loader component

* Updates go-tester to test loader

* Add boolean to @HostBinding animation

* Bug ie edge cases (#91)

* Fixes IE and Edge bugs with components for v1.1

* Removes 'x' on search input

* Fix title attr and center alignment

* Implemented styles and functionality for a mobile layout (#94)

* [Feature] Go-Action-Sheet (#90)

* Added the ability to provide actions on a table in a toolbar at the top (#97)

* Renames title to panelContent to avoid conflicts with native functionality (#98)

We had an issue with the <go-panel> component where the title @input
was exposing things we didn't want it to because of its naming
collision with the native title attribute. Updating the name of said
attribute to panelContent fixes this issue.

* Fixes compilation errors in the navigation components due to type checking
@grahamhency grahamhency mentioned this pull request Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamhency grahamhency grahamhency approved these changes

@AlexOverbeck AlexOverbeck Awaiting requested review from AlexOverbeck

Assignees

@AlexOverbeck AlexOverbeck

@grahamhency grahamhency

Labels
chore General chore or maintenance task
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredami @AlexOverbeck @grahamhency