V1.1.0 #102
Merged
V1.1.0 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds all files necessary for GoIconButtonComponent Creates a component for button with icons with no text.
[Feature] Go Layout
Fixes animation errors in firefox
Firefox Search Animation Errors
Z-index mappings
* Fixes issue with loader svg in Safari. Closes #82 There was an issue in the Safari browser where the loading svg would look like three black circles. This was a result of there being duplicate IDs within the svgs markup. Generating unique IDs and applying the fill to the paths inline based on those unique IDs fixes this problem. * Implements new version of the loading svg The previous version of the loading svg had some issues in specific browsers becuase it was reliant on gradient filters. This redesigns the svg to no longer use gradients and uses angular to do some of the animations on the host element. * Adds tests for go-loader component * Updates go-tester to test loader * Add boolean to @HostBinding animation
* Fixes IE and Edge bugs with components for v1.1 * Removes 'x' on search input * Fix title attr and center alignment
Compilation Errors Fix
AlexOverbeck
requested review from
StevenUlmer,
grahamhency,
devchris and
jaredami
StevenUlmer
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V1.1 codename: go shell 🐢🐢
Notable New Components
GoLayoutComponent
The
GoLayoutComponentserves as a new starting point for goponents. It introduces an app wide wrapper around much of our core functionality.GoLayoutComponentautomatically implements things like<go-modal>,<go-off-canvas>, and<go-toaster>.Fixes and Improvements
Fixes issues with the loading spinner
There were some tweaks made to the loading spinner that helps it display better various browsers. The loader can now easily be animated in and out with a
*ngIf.Related PRs
Fixes empty column on go-table components
There was an issue in that would throw an error in instances where we tried to create a table column with no data in it.
Related PRs
Adds support for various IE related things
There were several improvements made to avoid issues that we might have run into with IE.
Related PRs