Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI darker than normal when change to linear color space #57

Closed
PZZZB opened this issue Oct 23, 2019 · 4 comments
Closed

UI darker than normal when change to linear color space #57

PZZZB opened this issue Oct 23, 2019 · 4 comments
Assignees
@mob-sakai
Labels
bug Something isn't working released on @preview

Comments

@PZZZB
Copy link

PZZZB commented Oct 23, 2019 •
edited
Loading

In gamma space,there is no issue.
but when change color space from gamma to Linear.
The UIParticle become darker than normal.

image

same params:
image
@mob-sakai mob-sakai self-assigned this Oct 23, 2019
@mob-sakai mob-sakai added the question Further information is requested label Oct 23, 2019
@mob-sakai
Copy link
Owner

Hi @PuzzledBoy

Thank you for your feedback.
I would like to know more information on this issue.

Can you attach a minimal repro project for this issue?

@PZZZB
Copy link
Author

PZZZB commented Oct 24, 2019 •
edited
Loading

Hi,@mob-sakai ,thanks your reply.

Here is a small package that reproduce the issue:
Issue57.zip

Export from Unity 2019.3,default render pipeline,inside has a preset file make sure both normal particle and ui particles has same params.
And don't forget change color space to linear.

Thanks again.

@mob-sakai mob-sakai added bug Something isn't working and removed question Further information is requested labels Nov 18, 2019
@mob-sakai
Copy link
Owner

WIP

Unity_2018_3_11f1_Personal_-Issue_57_unity-ParticleForUGUI-PC__Mac___Linux_Standalone__Personal___Metal

Unity_2018_3_11f1_Personal_-Issue_57_unity-ParticleForUGUI-PC__Mac___Linux_Standalone__Personal___Metal-2

mob-sakai pushed a commit that referenced this issue Feb 12, 2020
fix: UI darker than normal when change to linear color space
db4d8a7 
Close #57
github-actions bot pushed a commit that referenced this issue Feb 12, 2020
@semantic-release-bot
chore(release): 3.0.0-preview.1 [skip ci]
fb7dd26 
# [3.0.0-preview.1](v2.3.0...v3.0.0-preview.1) (2020-02-12)

### Bug Fixes

* change the text in the inspector to make it more understandable. ([7ca0b6f](7ca0b6f)), closes [#66](#66)
* editor crashes when mesh is set to null when ParticleSystem.RenderMode=Mesh ([e5ebadd](e5ebadd)), closes [#69](#69)
* getting massive errors on editor ([ef82fa8](ef82fa8)), closes [#67](#67)
* heavy editor UI ([d3b470a](d3b470a))
* remove a menu to add overlay camera ([f5d3b6e](f5d3b6e))
* rotating the particle rect may cause out of bounds ([3439842](3439842)), closes [#55](#55)
* scale will be decrease on editor ([0c59846](0c59846))
* UI darker than normal when change to linear color space ([db4d8a7](db4d8a7)), closes [#57](#57)

### Build System

* update develop environment ([9fcf169](9fcf169))

### Features

* add menu to import sample ([b8b1827](b8b1827))
* add samples test ([287b5cc](287b5cc))
* **editor:** add osc package (portable mode) ([6c7f880](6c7f880))

### BREAKING CHANGES

* update develop environment to Unity 2018.3.
Unity 2018.2 will continue to be supported.
github-actions bot pushed a commit that referenced this issue Feb 12, 2020
@semantic-release-bot
3.0.0-preview.1
a4cbebe 
# [3.0.0-preview.1](v2.3.0...v3.0.0-preview.1) (2020-02-12)

### Bug Fixes

* change the text in the inspector to make it more understandable. ([7ca0b6f](7ca0b6f)), closes [#66](#66)
* editor crashes when mesh is set to null when ParticleSystem.RenderMode=Mesh ([e5ebadd](e5ebadd)), closes [#69](#69)
* getting massive errors on editor ([ef82fa8](ef82fa8)), closes [#67](#67)
* heavy editor UI ([d3b470a](d3b470a))
* remove a menu to add overlay camera ([f5d3b6e](f5d3b6e))
* rotating the particle rect may cause out of bounds ([3439842](3439842)), closes [#55](#55)
* scale will be decrease on editor ([0c59846](0c59846))
* UI darker than normal when change to linear color space ([db4d8a7](db4d8a7)), closes [#57](#57)

### Build System

* update develop environment ([9fcf169](9fcf169))

### Features

* add menu to import sample ([b8b1827](b8b1827))
* add samples test ([287b5cc](287b5cc))
* **editor:** add osc package (portable mode) ([6c7f880](6c7f880))

### BREAKING CHANGES

* update develop environment to Unity 2018.3.
Unity 2018.2 will continue to be supported.
@mob-sakai
Copy link
Owner

🎉 This issue has been resolved in version 3.0.0-preview.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

LionelPerrault added a commit to LionelPerrault/Unity-Particle that referenced this issue Jul 25, 2023
@LionelPerrault
3.0.0-preview.1
ab8e3c9 
# [3.0.0-preview.1](mob-sakai/ParticleEffectForUGUI@v2.3.0...v3.0.0-preview.1) (2020-02-12)

### Bug Fixes

* change the text in the inspector to make it more understandable. ([7ca0b6f](mob-sakai/ParticleEffectForUGUI@7ca0b6f)), closes [#66](mob-sakai/ParticleEffectForUGUI#66)
* editor crashes when mesh is set to null when ParticleSystem.RenderMode=Mesh ([e5ebadd](mob-sakai/ParticleEffectForUGUI@e5ebadd)), closes [#69](mob-sakai/ParticleEffectForUGUI#69)
* getting massive errors on editor ([ef82fa8](mob-sakai/ParticleEffectForUGUI@ef82fa8)), closes [#67](mob-sakai/ParticleEffectForUGUI#67)
* heavy editor UI ([d3b470a](mob-sakai/ParticleEffectForUGUI@d3b470a))
* remove a menu to add overlay camera ([f5d3b6e](mob-sakai/ParticleEffectForUGUI@f5d3b6e))
* rotating the particle rect may cause out of bounds ([3439842](mob-sakai/ParticleEffectForUGUI@3439842)), closes [#55](mob-sakai/ParticleEffectForUGUI#55)
* scale will be decrease on editor ([0c59846](mob-sakai/ParticleEffectForUGUI@0c59846))
* UI darker than normal when change to linear color space ([db4d8a7](mob-sakai/ParticleEffectForUGUI@db4d8a7)), closes [#57](mob-sakai/ParticleEffectForUGUI#57)

### Build System

* update develop environment ([9fcf169](mob-sakai/ParticleEffectForUGUI@9fcf169))

### Features

* add menu to import sample ([b8b1827](mob-sakai/ParticleEffectForUGUI@b8b1827))
* add samples test ([287b5cc](mob-sakai/ParticleEffectForUGUI@287b5cc))
* **editor:** add osc package (portable mode) ([6c7f880](mob-sakai/ParticleEffectForUGUI@6c7f880))

### BREAKING CHANGES

* update develop environment to Unity 2018.3.
Unity 2018.2 will continue to be supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
bug Something isn't working released on @preview
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PZZZB @mob-sakai