Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate the particle rect ,May cause out of bounds #55

Closed
Liiiz opened this issue Oct 15, 2019 · 2 comments
Closed

Rotate the particle rect ,May cause out of bounds #55

Liiiz opened this issue Oct 15, 2019 · 2 comments
Assignees
@mob-sakai
Labels
bug Something isn't working released on @preview

Comments

@Liiiz
Copy link

Liiiz commented Oct 15, 2019

Particle not use shape, mode is billboard.
I Rotate the rect to (90, 0 , 0), some paticle the render will no work.

i try this to solve：
if (0 < m_ParticleSystem.particleCount)
{
....
_mesh.SetVertices(s_Vertices);
//Recalculate the bounds
_mesh.RecalculateBounds();
....
}
@Liiiz Liiiz closed this as completed Oct 15, 2019
@Liiiz Liiiz reopened this Oct 15, 2019
@mob-sakai mob-sakai self-assigned this Oct 15, 2019
@mob-sakai mob-sakai added the bug Something isn't working label Oct 15, 2019
@mob-sakai
Copy link
Owner

Hi @Liiiz

Thank you for your reporting!

@mob-sakai mob-sakai mentioned this issue Dec 8, 2019
Closed
mob-sakai pushed a commit that referenced this issue Feb 12, 2020
fix: rotating the particle rect may cause out of bounds
3439842 
Close #55
github-actions bot pushed a commit that referenced this issue Feb 12, 2020
@semantic-release-bot
chore(release): 3.0.0-preview.1 [skip ci]
fb7dd26 
# [3.0.0-preview.1](v2.3.0...v3.0.0-preview.1) (2020-02-12)

### Bug Fixes

* change the text in the inspector to make it more understandable. ([7ca0b6f](7ca0b6f)), closes [#66](#66)
* editor crashes when mesh is set to null when ParticleSystem.RenderMode=Mesh ([e5ebadd](e5ebadd)), closes [#69](#69)
* getting massive errors on editor ([ef82fa8](ef82fa8)), closes [#67](#67)
* heavy editor UI ([d3b470a](d3b470a))
* remove a menu to add overlay camera ([f5d3b6e](f5d3b6e))
* rotating the particle rect may cause out of bounds ([3439842](3439842)), closes [#55](#55)
* scale will be decrease on editor ([0c59846](0c59846))
* UI darker than normal when change to linear color space ([db4d8a7](db4d8a7)), closes [#57](#57)

### Build System

* update develop environment ([9fcf169](9fcf169))

### Features

* add menu to import sample ([b8b1827](b8b1827))
* add samples test ([287b5cc](287b5cc))
* **editor:** add osc package (portable mode) ([6c7f880](6c7f880))

### BREAKING CHANGES

* update develop environment to Unity 2018.3.
Unity 2018.2 will continue to be supported.
github-actions bot pushed a commit that referenced this issue Feb 12, 2020
@semantic-release-bot
3.0.0-preview.1
a4cbebe 
# [3.0.0-preview.1](v2.3.0...v3.0.0-preview.1) (2020-02-12)

### Bug Fixes

* change the text in the inspector to make it more understandable. ([7ca0b6f](7ca0b6f)), closes [#66](#66)
* editor crashes when mesh is set to null when ParticleSystem.RenderMode=Mesh ([e5ebadd](e5ebadd)), closes [#69](#69)
* getting massive errors on editor ([ef82fa8](ef82fa8)), closes [#67](#67)
* heavy editor UI ([d3b470a](d3b470a))
* remove a menu to add overlay camera ([f5d3b6e](f5d3b6e))
* rotating the particle rect may cause out of bounds ([3439842](3439842)), closes [#55](#55)
* scale will be decrease on editor ([0c59846](0c59846))
* UI darker than normal when change to linear color space ([db4d8a7](db4d8a7)), closes [#57](#57)

### Build System

* update develop environment ([9fcf169](9fcf169))

### Features

* add menu to import sample ([b8b1827](b8b1827))
* add samples test ([287b5cc](287b5cc))
* **editor:** add osc package (portable mode) ([6c7f880](6c7f880))

### BREAKING CHANGES

* update develop environment to Unity 2018.3.
Unity 2018.2 will continue to be supported.
@mob-sakai
Copy link
Owner

🎉 This issue has been resolved in version 3.0.0-preview.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

LionelPerrault added a commit to LionelPerrault/Unity-Particle that referenced this issue Jul 25, 2023
@LionelPerrault
3.0.0-preview.1
ab8e3c9 
# [3.0.0-preview.1](mob-sakai/ParticleEffectForUGUI@v2.3.0...v3.0.0-preview.1) (2020-02-12)

### Bug Fixes

* change the text in the inspector to make it more understandable. ([7ca0b6f](mob-sakai/ParticleEffectForUGUI@7ca0b6f)), closes [#66](mob-sakai/ParticleEffectForUGUI#66)
* editor crashes when mesh is set to null when ParticleSystem.RenderMode=Mesh ([e5ebadd](mob-sakai/ParticleEffectForUGUI@e5ebadd)), closes [#69](mob-sakai/ParticleEffectForUGUI#69)
* getting massive errors on editor ([ef82fa8](mob-sakai/ParticleEffectForUGUI@ef82fa8)), closes [#67](mob-sakai/ParticleEffectForUGUI#67)
* heavy editor UI ([d3b470a](mob-sakai/ParticleEffectForUGUI@d3b470a))
* remove a menu to add overlay camera ([f5d3b6e](mob-sakai/ParticleEffectForUGUI@f5d3b6e))
* rotating the particle rect may cause out of bounds ([3439842](mob-sakai/ParticleEffectForUGUI@3439842)), closes [#55](mob-sakai/ParticleEffectForUGUI#55)
* scale will be decrease on editor ([0c59846](mob-sakai/ParticleEffectForUGUI@0c59846))
* UI darker than normal when change to linear color space ([db4d8a7](mob-sakai/ParticleEffectForUGUI@db4d8a7)), closes [#57](mob-sakai/ParticleEffectForUGUI#57)

### Build System

* update develop environment ([9fcf169](mob-sakai/ParticleEffectForUGUI@9fcf169))

### Features

* add menu to import sample ([b8b1827](mob-sakai/ParticleEffectForUGUI@b8b1827))
* add samples test ([287b5cc](mob-sakai/ParticleEffectForUGUI@287b5cc))
* **editor:** add osc package (portable mode) ([6c7f880](mob-sakai/ParticleEffectForUGUI@6c7f880))

### BREAKING CHANGES

* update develop environment to Unity 2018.3.
Unity 2018.2 will continue to be supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
bug Something isn't working released on @preview
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mob-sakai @Liiiz