Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hand cursor from author location #354

Closed
wants to merge 2 commits into from
Closed

Remove hand cursor from author location #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c6b27
Remove hand cursor from author location
amweiss Jun 11, 2016
5645974
Add compiled css
amweiss Jun 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/author-profile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ <h3 class="author__name">{{ author.name }}</h3>
<button class="btn btn--inverse">Follow</button>
<ul class="author__urls social-icons">
{% if author.location %}
<li><i class="fa fa-fw fa-map-marker" aria-hidden="true"></i> {{ author.location }}</li>
<li class="author__location"><i class="fa fa-fw fa-map-marker" aria-hidden="true"></i> {{ author.location }}</li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a closer look and adding the author__location class to the <li> element is unnecessary. As is the .author__location declaration in _sidebar.scss.

If cursor: default is added to .author__urls here you can get away with adding a single line and not having to mess with the sidebar's markup.

{% endif %}
{% if author.uri %}
<li><a href="{{ author.uri }}"><i class="fa fa-fw fa-chain" aria-hidden="true"></i> {{ site.data.ui-text[site.locale].website_label }}</a></li>
Expand Down
4 changes: 4 additions & 0 deletions assets/_scss/_sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@
}
}

.author__location {
cursor: default;
}

@include breakpoint($large) {
display: block;
}
Expand Down
2 changes: 1 addition & 1 deletion assets/css/main.css
View file
Open in desktop

Large diffs are not rendered by default.