Remove hand cursor from author location #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run |
|
Added. |
| @@ -23,7 +23,7 @@ <h3 class="author__name">{{ author.name }}</h3> | |||
| <button class="btn btn--inverse">Follow</button> | |||
| <ul class="author__urls social-icons"> | |||
| {% if author.location %} | |||
| <li><i class="fa fa-fw fa-map-marker" aria-hidden="true"></i> {{ author.location }}</li> | |||
| <li class="author__location"><i class="fa fa-fw fa-map-marker" aria-hidden="true"></i> {{ author.location }}</li> | |||
There was a problem hiding this comment.
Took a closer look and adding the author__location class to the <li> element is unnecessary. As is the .author__location declaration in _sidebar.scss.
If cursor: default is added to .author__urls here you can get away with adding a single line and not having to mess with the sidebar's markup.
mmistakes
added a commit
that referenced
this pull request
Jun 13, 2016
… surrounding links. - Close #354
sobkowiak
pushed a commit
to sobkowiak/sobkowiak.github.io-new
that referenced
this pull request
Jul 18, 2016
… surrounding links. - Close mmistakes#354
sobkowiak
pushed a commit
to sobkowiak/sobkowiak.github.io-new
that referenced
this pull request
Jul 18, 2016
… surrounding links. - Close mmistakes#354
jluccisano
added a commit
to jluccisano/jluccisano.github.io
that referenced
this pull request
May 6, 2017
… surrounding links. - Close mmistakes#354
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this pull request
May 18, 2022
… surrounding links. - Close mmistakes#354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.