Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config #72

Merged
merged 6 commits into from
Sep 16, 2014
Merged

Fix config #72

merged 6 commits into from
Sep 16, 2014

Conversation

krmaxwell
Copy link
Member

Ready for testing

Implement changes in #68

@krmaxwell
Copy link
Member Author

go go @alexcpsec

@alexcpsec
Copy link
Member

So... many... PRs...

@krmaxwell
Copy link
Member Author

Do you want me to stop working on Combine? :trollface:

@alexcpsec
Copy link
Member

LOL! No, keep up the good work ;)

@alexcpsec
Copy link
Member

Why do we have SafeConfigParser on reaper.py and ConfigParser on the other ones? Can't they all be "safe"?

@krmaxwell
Copy link
Member Author

ah, good catch, I was trying to figure something out.

@alexcpsec
Copy link
Member

Made a change so every file checks for the .cfg file. As it were, Thresher and Baler would run anyway.

@alexcpsec
Copy link
Member

This seems good to go on my end. Waiting your approval on my change.

@krmaxwell
Copy link
Member Author

Good catch on baler (and the output). I'd left it out of Thresher because it doesn't use any configs and is therefore spurious.

@alexcpsec
Copy link
Member

The issue is that then Thresher runs anyway and either runs in an old harvest.json or errors out. This is why I added the check on it even though it does not use it.

@krmaxwell
Copy link
Member Author

Eh, might as well keep the check since it's going to have configs eventually from #23

@alexcpsec
Copy link
Member

:shipit: ?

@krmaxwell
Copy link
Member Author

:shipit:

alexcpsec added a commit that referenced this pull request Sep 16, 2014
@alexcpsec alexcpsec merged commit b42ddf7 into master Sep 16, 2014
@alexcpsec alexcpsec deleted the i68_config branch September 16, 2014 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants