Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the combine.cfg file to a combine-default.cfg #68

Closed
3 tasks done
alexcpsec opened this issue Sep 15, 2014 · 4 comments
Closed
3 tasks done

Move the combine.cfg file to a combine-default.cfg #68

alexcpsec opened this issue Sep 15, 2014 · 4 comments
Assignees

Comments

@alexcpsec
Copy link
Member

So we can have a standard .cfg file and people (including myself) can edit their config files with their information without fear of commiting their API key (like I almost did right now).

  • Move combine.cfg to combine-example.cfg
  • Add combine.cfg to .gitignore
  • All instances of ConfigParser should note the existence of combine-example.cfg if combine.cfg is not found and output an appropriately helpful error message, then exit.
@alexcpsec alexcpsec self-assigned this Sep 15, 2014
@alexcpsec
Copy link
Member Author

@technoskald do you have any input on this? Is this really the best way to get this done? Is this a recognizable pattern in tools like this?

@krmaxwell
Copy link
Member

So the first and second points are common (and trivial). But I would do it as:

  • Move combine.cfg to combine-example.cfg
  • Add combine.cfg to .gitignore
  • All instances of ConfigParser should note the existence of combine-example.cfg if combine.cfg is not found and output an appropriately helpful error message, then exit.

@alexcpsec
Copy link
Member Author

Agree. Want me to do this, or can you take care of it?

@krmaxwell
Copy link
Member

I will work on it.

@krmaxwell krmaxwell assigned krmaxwell and unassigned alexcpsec Sep 15, 2014
@krmaxwell krmaxwell mentioned this issue Sep 15, 2014
alexcpsec added a commit that referenced this issue Sep 16, 2014
…he process. This is begging for refactoring (#68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants