Skip to content

Commit

Permalink
- Remove nodeHarvest learners (#2841)
Browse files Browse the repository at this point in the history
  • Loading branch information
pat-s authored Jul 17, 2022
1 parent 2741c26 commit 999e66e
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ Suggests:
mRMRe,
neuralnet,
nnet,
nodeHarvest (>= 0.7-3),
numDeriv,
pamr,
pander,
Expand Down
6 changes: 0 additions & 6 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ S3method(makeRLearner,classif.naiveBayes)
S3method(makeRLearner,classif.neuralnet)
S3method(makeRLearner,classif.nnTrain)
S3method(makeRLearner,classif.nnet)
S3method(makeRLearner,classif.nodeHarvest)
S3method(makeRLearner,classif.pamr)
S3method(makeRLearner,classif.penalized)
S3method(makeRLearner,classif.plr)
Expand Down Expand Up @@ -277,7 +276,6 @@ S3method(makeRLearner,regr.lm)
S3method(makeRLearner,regr.mars)
S3method(makeRLearner,regr.mob)
S3method(makeRLearner,regr.nnet)
S3method(makeRLearner,regr.nodeHarvest)
S3method(makeRLearner,regr.pcr)
S3method(makeRLearner,regr.penalized)
S3method(makeRLearner,regr.plsr)
Expand Down Expand Up @@ -385,7 +383,6 @@ S3method(predictLearner,classif.naiveBayes)
S3method(predictLearner,classif.neuralnet)
S3method(predictLearner,classif.nnTrain)
S3method(predictLearner,classif.nnet)
S3method(predictLearner,classif.nodeHarvest)
S3method(predictLearner,classif.pamr)
S3method(predictLearner,classif.penalized)
S3method(predictLearner,classif.plr)
Expand Down Expand Up @@ -460,7 +457,6 @@ S3method(predictLearner,regr.lm)
S3method(predictLearner,regr.mars)
S3method(predictLearner,regr.mob)
S3method(predictLearner,regr.nnet)
S3method(predictLearner,regr.nodeHarvest)
S3method(predictLearner,regr.pcr)
S3method(predictLearner,regr.penalized)
S3method(predictLearner,regr.plsr)
Expand Down Expand Up @@ -633,7 +629,6 @@ S3method(trainLearner,classif.naiveBayes)
S3method(trainLearner,classif.neuralnet)
S3method(trainLearner,classif.nnTrain)
S3method(trainLearner,classif.nnet)
S3method(trainLearner,classif.nodeHarvest)
S3method(trainLearner,classif.pamr)
S3method(trainLearner,classif.penalized)
S3method(trainLearner,classif.plr)
Expand Down Expand Up @@ -708,7 +703,6 @@ S3method(trainLearner,regr.lm)
S3method(trainLearner,regr.mars)
S3method(trainLearner,regr.mob)
S3method(trainLearner,regr.nnet)
S3method(trainLearner,regr.nodeHarvest)
S3method(trainLearner,regr.pcr)
S3method(trainLearner,regr.penalized)
S3method(trainLearner,regr.plsr)
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test_learners_all_classif.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ test_that("learners work: classif", {
classif.earth = list(degree = 3L, nprune = 2L),
classif.gbm = list(bag.fraction = 1, n.minobsinnode = 1),
classif.lssvm = list(kernel = "rbfdot", reduced = FALSE),
classif.nodeHarvest = list(nodes = 100L, nodesize = 5L),
classif.xyf = list(ydim = 2L),
classif.h2o.deeplearning = list(hidden = 2L),
classif.FDboost = list(mstop = 2L)
Expand Down
3 changes: 0 additions & 3 deletions tests/testthat/test_learners_all_regr.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ test_that("learners work: regr ", {
# see above
replace_missing_data_with_x_j_bar = TRUE,
num_iterations_after_burn_in = 10L),
regr.nodeHarvest = list(nodes = 100L, nodesize = 5L),
regr.h2o.deeplearning = list(hidden = 2L),
regr.ranger = list(keep.inbag = TRUE)
)
Expand Down Expand Up @@ -73,7 +72,6 @@ test_that("learners work: regr ", {
lrns = suppressMessages(listLearnersCustom(min.task, create = TRUE))
# regr.gbm: Meaningfull error about too small dataset
# regr.cforest: Error in model@fit(data, ...) : fraction of 0.000000 is too small
# regr.nodeHarvest: Error in ZRULES[[1]] : subscript out of bounds
# others: see learners_all_classif and random errors
not.working = c(
"regr.cforest",
Expand All @@ -83,7 +81,6 @@ test_that("learners work: regr ", {
"regr.gbm",
"regr.glmnet",
"regr.laGP",
"regr.nodeHarvest",
"regr.slim")
lrns = lrns[extractSubList(lrns, "id", simplify = TRUE) %nin% not.working]
foo = suppressWarnings(lapply(lrns, testBasicLearnerProperties, task = min.task,
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test_learners_classiflabelswitch.R
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ hpars = list(
classif.LiblineaRLogReg = list(type = 7),
classif.LiblineaRBinary = list(type = 1),
classif.LiblineaRMultiClass = list(type = 1),
classif.nodeHarvest = list(nodes = 100L, maxinter = 1L),
classif.FDboost = list(mstop = 10L)
)

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 999e66e

Please sign in to comment.