Skip to content

Commit

Permalink
- Remove rknn learner (#2842)
Browse files Browse the repository at this point in the history
  • Loading branch information
pat-s authored Jul 17, 2022
1 parent e456266 commit 2741c26
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 10 deletions.
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ Suggests:
rex,
rFerns,
rgenoud,
rknn,
rmarkdown,
Rmpi,
ROCR,
Expand Down
6 changes: 0 additions & 6 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ S3method(makeRLearner,classif.rFerns)
S3method(makeRLearner,classif.randomForest)
S3method(makeRLearner,classif.ranger)
S3method(makeRLearner,classif.rda)
S3method(makeRLearner,classif.rknn)
S3method(makeRLearner,classif.rotationForest)
S3method(makeRLearner,classif.rpart)
S3method(makeRLearner,classif.saeDNN)
Expand Down Expand Up @@ -284,7 +283,6 @@ S3method(makeRLearner,regr.penalized)
S3method(makeRLearner,regr.plsr)
S3method(makeRLearner,regr.randomForest)
S3method(makeRLearner,regr.ranger)
S3method(makeRLearner,regr.rknn)
S3method(makeRLearner,regr.rpart)
S3method(makeRLearner,regr.rsm)
S3method(makeRLearner,regr.rvm)
Expand Down Expand Up @@ -398,7 +396,6 @@ S3method(predictLearner,classif.rFerns)
S3method(predictLearner,classif.randomForest)
S3method(predictLearner,classif.ranger)
S3method(predictLearner,classif.rda)
S3method(predictLearner,classif.rknn)
S3method(predictLearner,classif.rotationForest)
S3method(predictLearner,classif.rpart)
S3method(predictLearner,classif.saeDNN)
Expand Down Expand Up @@ -469,7 +466,6 @@ S3method(predictLearner,regr.penalized)
S3method(predictLearner,regr.plsr)
S3method(predictLearner,regr.randomForest)
S3method(predictLearner,regr.ranger)
S3method(predictLearner,regr.rknn)
S3method(predictLearner,regr.rpart)
S3method(predictLearner,regr.rsm)
S3method(predictLearner,regr.rvm)
Expand Down Expand Up @@ -648,7 +644,6 @@ S3method(trainLearner,classif.rFerns)
S3method(trainLearner,classif.randomForest)
S3method(trainLearner,classif.ranger)
S3method(trainLearner,classif.rda)
S3method(trainLearner,classif.rknn)
S3method(trainLearner,classif.rotationForest)
S3method(trainLearner,classif.rpart)
S3method(trainLearner,classif.saeDNN)
Expand Down Expand Up @@ -719,7 +714,6 @@ S3method(trainLearner,regr.penalized)
S3method(trainLearner,regr.plsr)
S3method(trainLearner,regr.randomForest)
S3method(trainLearner,regr.ranger)
S3method(trainLearner,regr.rknn)
S3method(trainLearner,regr.rpart)
S3method(trainLearner,regr.rsm)
S3method(trainLearner,regr.rvm)
Expand Down
5 changes: 2 additions & 3 deletions tests/testthat/test_learners_all_classif.R
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ test_that("learners work: classif", {
y = as.factor(rep(c("a", "b"), each = 5))), target = "y")
lrns = listLearnersCustom(min.task, create = TRUE)
# FIXME: classif.boosting: Remove if bug is removed in adabag!
# FIXME: classif.rknn: Remove if bug is removed in rknn::rknn!
# classif.cvglmnet does not claim to work for 1d problems
# classif.dbnDNN, classif.evtree, classif.lqa
# (not im mlr anymore),
Expand All @@ -112,8 +111,8 @@ test_that("learners work: classif", {
"classif.mda",
"classif.pamr",
"classif.plsdaCaret",
"classif.rotationForest",
"classif.rknn")
"classif.rotationForest"
)
lrns_sub = lrns[extractSubList(lrns, "id", simplify = TRUE) %nin% not.working]
foo = suppressWarnings(lapply(lrns_sub, testBasicLearnerProperties,
task = min.task,
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 2741c26

Please sign in to comment.