2.4.0 changelog #4210

daschuer · 2021-08-16T06:46:04Z

No description provided.

coveralls · 2021-08-16T07:26:04Z

Pull Request Test Coverage Report for Build 1142456358

0 of 0 changed or added relevant lines in 0 files are covered.
1402 unchanged lines in 18 files lost coverage.
Overall coverage decreased (-0.03%) to 25.966%

Files with Coverage Reduction	New Missed Lines	%
src/library/basetracktablemodel.cpp	2	21.91%
src/library/browse/browsetablemodel.cpp	2	0%
src/library/trackcollectionmanager.cpp	3	12.46%
src/engine/readaheadmanager.cpp	7	90.83%
src/engine/enginebuffer.cpp	13	86.4%
src/library/proxytrackmodel.cpp	16	0%
src/widget/wlibrarysidebar.cpp	16	0%
src/engine/controls/clockcontrol.cpp	17	71.96%
src/engine/controls/cuecontrol.cpp	21	68.8%
src/skin/qml/qmlplayerproxy.cpp	39	0%

Totals
Change from base Build 1133524699:	-0.03%
Covered Lines:	20005
Relevant Lines:	77044

💛 - Coveralls

CHANGELOG.md

Swiftb0y · 2021-08-16T09:47:27Z

CHANGELOG.md

+  [#4186](https://github.com/mixxxdj/mixxx/pull/4186)
+
+### Controller ###
+* ES6 based controller mapping system with module support


Suggested change

* ES6 based controller mapping system with module support

* ES6 based controller mapping system

Using ES6 modules is still not possible as we're not loading the mappings as a module.

Maybe we should even explicitly mention that its not supported for now so people don't get confused when they expect it to be supported because ES6 support mandates it.

For my understanding #2868 enabled the module support. Is it not yet usable?

Anyway, I have improved the sentences to "Prepare code for upcoming ES6 based controller mapping system with module support" does it fit?

For my understanding #2868 enabled the module support. Is it not yet usable?

Oh wow, I forgot about that PR entirely. I guess we technically do have module support, however, we have absolutely 0 docs or already written code that demonstrate this.

Anyway, I have improved the sentences to "Prepare code for upcoming ES6 based controller mapping system with module support" does it fit?

The situation is too complex to describe in two sentences IMO so I don't care how we phrase it exactly. More important is that we document situation ASAP.

There is no way to load ES6 modules currently.

Swiftb0y · 2021-08-16T09:51:53Z

CHANGELOG.md

+* Don't allow waveforms to obtain input focus [#4128](https://github.com/mixxxdj/mixxx/pull/4128)
+* Inverted scroll wheel waveform zoom direction to mach other applications [#4195](https://github.com/mixxxdj/mixxx/pull/4195)


already part of 2.3.1

No, it was merged to main.

My bad, #4195 did only go into main, but #4128 was opened against 2.3 as well (#4134).

yep, the fix was back-ported to 2.3

Swiftb0y · 2021-08-16T09:53:23Z

CHANGELOG.md

+  [#2980](https://github.com/mixxxdj/mixxx/pull/2980)
+  [#3006](https://github.com/mixxxdj/mixxx/pull/3006)
+* Logging: Add support for QT_MESSAGE_PATTERN env var [#3204](https://github.com/mixxxdj/mixxx/pull/3204)
+* Colored logging console output and other improvements


I dislike the "[...] and other improvements".

Swiftb0y · 2021-08-16T09:54:30Z

CHANGELOG.md

+  [#4036](https://github.com/mixxxdj/mixxx/pull/4036)
+  [#4170](https://github.com/mixxxdj/mixxx/pull/4170)
+  [#4057](https://github.com/mixxxdj/mixxx/pull/4057)
+* Added the Recordbox Hotcue Color Palette [#3746](https://github.com/mixxxdj/mixxx/pull/3746)


already part of 2.3.0

I don't think so, maybe the description was misleading. Improved.

Same issue as with the other PR. the PR linked is part of main, but the actual feature / commit has also been merged into 2.3 in #3749

Co-authored-by: Swiftb0y <[email protected]>

daschuer · 2021-08-16T11:12:17Z

Done

Swiftb0y

LGTM. Does someone else also want to have a look?

Holzhaus · 2021-08-17T12:00:43Z

CHANGELOG.md

@@ -2,10 +2,349 @@

 ## [2.4.0](https://launchpad.net/mixxx/+milestone/2.4.0) (Unreleased)

-* Cover art: Prevent wrong cover art display due to hash conflicts
-* Cover art: Add background color for quick cover art preview
+### Cover Art ###


Suggested change

### Cover Art ###

### Cover Art

And everywhere else

Holzhaus · 2021-08-17T12:01:08Z

CHANGELOG.md

+* Add background color for quick cover art preview [#2524](https://github.com/mixxxdj/mixxx/pull/2524)
+
+### Music Library ###
+* Ensure that tracks with an invalid bpm are re-analyzed [#2776](https://github.com/mixxxdj/mixxx/pull/2776)


Suggested change

* Ensure that tracks with an invalid bpm are re-analyzed [#2776](https://github.com/mixxxdj/mixxx/pull/2776)

* Ensure that tracks with an invalid BPM are re-analyzed [#2776](https://github.com/mixxxdj/mixxx/pull/2776)

CHANGELOG.md

Holzhaus · 2021-08-17T12:04:04Z

CHANGELOG.md

+  [#4143](https://github.com/mixxxdj/mixxx/pull/4143)
+* Rekordbox: Save all loops and correct AAC timing offset for CoreAudio [#2779](https://github.com/mixxxdj/mixxx/pull/2779)
+* Improve messages during schema migration [#2979](https://github.com/mixxxdj/mixxx/pull/2979)
+* Fix "[Library],GoToItem" in tracks table [#3196](https://github.com/mixxxdj/mixxx/pull/3196)


Is this broken in 2.3? Or is this a regression fix? In that case it should not be part of the changelog.

This has been backported to 2.3.0 .. removed.

CHANGELOG.md

Holzhaus · 2021-08-17T12:38:19Z

CHANGELOG.md

+  [#4036](https://github.com/mixxxdj/mixxx/pull/4036)
+  [#4170](https://github.com/mixxxdj/mixxx/pull/4170)
+  [#4057](https://github.com/mixxxdj/mixxx/pull/4057)
+* Rename Master EQ to Main EQ for an inclusive language [#3868](https://github.com/mixxxdj/mixxx/pull/3868)


Make use of inclusive language is already mentioned above

CHANGELOG.md

Holzhaus · 2021-08-17T12:40:27Z

CHANGELOG.md

+* Rename Master EQ to Main EQ for an inclusive language [#3868](https://github.com/mixxxdj/mixxx/pull/3868)
+* Improve message when dealing with macOs sandbox [#4018](https://github.com/mixxxdj/mixxx/pull/4018) [lp:1921541](https://bugs.launchpad.net/mixxx/+bug/1921541)
+* CONTRIBUTING.md: move content from DocuWiki [#2699](https://github.com/mixxxdj/mixxx/pull/2699)
+* Misc. refactorings


Do we really need to mention that? I guess no user will know what it means.

I was unsure about that. We may remove the whole block. For now I have kept it for completeness.
Ideas?

I think the current entry is not really helpful unless you read all the linked PRs. We could split it up (e.g. "Refactor XYZ", "Fix various compiler warnings", etc.), but I guess this is too much without real relevance to the user.

Or maybe something like "And many more fixes, improvements and cleanups. See the 2.4.0 milestone on GitHub for details."?

And many more fixes ..

Without the link is not a good idea, because the user will have hard time to find them among all others already listed above. Should I remove the whole block than, to not make the user curious?

Holzhaus · 2021-08-17T12:40:57Z

CHANGELOG.md

@@ -227,7 +566,7 @@
 * Fix HID controller output on Windows with common-hid-packet-parser.js
 * Fix rendering slow down by not using QStylePainter in WSpinny lp:1530720
 * Fix broken Mic mute button lp:1782568
-* added quick effect enable button to the control picker menu
+* added quick effect enable button to the control er menu


Please revert

Co-authored-by: Jan Holthuis <[email protected]>

daschuer · 2021-08-18T07:50:21Z

Done.

CHANGELOG.md

Co-authored-by: Jan Holthuis <[email protected]>

Holzhaus

LGTM, thank you very much for this tedious work.

Holzhaus · 2021-09-08T17:11:06Z

Unfortunately there are merge conflicts.

daschuer · 2021-09-08T20:09:52Z

Thank you for review. A follow up with the latest changes in in progress.

daschuer added 2 commits August 16, 2021 08:36

Update changelog

09dd5fd

Update changelog

f04ad6b

daschuer force-pushed the 2.4.0_changelog branch from 9b6df10 to f04ad6b Compare August 16, 2021 07:14

Swiftb0y requested changes Aug 16, 2021

View reviewed changes

daschuer and others added 3 commits August 16, 2021 12:38

Added missing link for PR mixxxdj#2524

da68870

Co-authored-by: Swiftb0y <[email protected]>

Add correct PRs to the ES6 section

55af6e5

Clarify that ES6 module support is not yet supported

7a0a658

daschuer force-pushed the 2.4.0_changelog branch from d5b156b to 7a0a658 Compare August 16, 2021 11:01

Explain change of PR mixxxdj#3518 explicit

ed84f44

daschuer force-pushed the 2.4.0_changelog branch from 64a985b to ed84f44 Compare August 16, 2021 11:08

Clarify description of mixxxdj#3746

5961784

Remove PRs that have been backported to 2.3

cb48766

Swiftb0y approved these changes Aug 17, 2021

View reviewed changes

Holzhaus reviewed Aug 17, 2021

View reviewed changes

daschuer and others added 14 commits August 18, 2021 09:05

remove redundant closing '###'

9231fb1

User capital BPM

3f12983

Improve description of Engine Prime section

b0e4f51

Co-authored-by: Jan Holthuis <[email protected]>

Remove mixxxdj#3196 which has been backported to 2.3.0 as mixxxdj#3194

b8d9bac

Improve description for mixxxdj#2979

dd557b6

Co-authored-by: Jan Holthuis <[email protected]>

Move mixxxdj#3868 to the inclusive paragraph

20a8eab

Fix macOS spelling

fb5f74d

Co-authored-by: Jan Holthuis <[email protected]>

Improve wording for last_played_at column

30f1bca

Co-authored-by: Jan Holthuis <[email protected]>

Improve description for mixxxdj#3811

4c182fd

Co-authored-by: Jan Holthuis <[email protected]>

Improved description for explicit leader

54dfc02

Co-authored-by: Jan Holthuis <[email protected]>

revert unintended change

f6499e8

User capital BPM

73e3c56

Improve various descriptions

41047ec

Co-authored-by: Jan Holthuis <[email protected]>

remove redundant mixxxdj#3076 entry

0ee41f3

remove redundant entry about QT_MESSAGE_PATTERN

dc44a3e

Fix spelling of non-existent

ef69bc9

Holzhaus mentioned this pull request Aug 18, 2021

Changelog Auto-Updater mixxxdj/manual#422

Merged

Holzhaus reviewed Sep 8, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Improve headlines for consistency

afbf85f

Co-authored-by: Jan Holthuis <[email protected]>

Holzhaus approved these changes Sep 8, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 2.4.0_changelog

0cabef1

Holzhaus merged commit 78a547f into mixxxdj:main Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.4.0 changelog #4210

2.4.0 changelog #4210

daschuer commented Aug 16, 2021

coveralls commented Aug 16, 2021 •

edited

Loading

Swiftb0y Aug 16, 2021

Swiftb0y Aug 16, 2021

daschuer Aug 16, 2021

daschuer Aug 16, 2021

Swiftb0y Aug 16, 2021

Be-ing Aug 16, 2021

Swiftb0y Aug 16, 2021

daschuer Aug 16, 2021

Swiftb0y Aug 16, 2021

ronso0 Aug 16, 2021

Swiftb0y Aug 16, 2021

Swiftb0y Aug 16, 2021

daschuer Aug 16, 2021

Swiftb0y Aug 16, 2021 •

edited

Loading

daschuer Aug 16, 2021

daschuer commented Aug 16, 2021

Swiftb0y left a comment

Holzhaus Aug 17, 2021

Holzhaus Aug 17, 2021

Holzhaus Aug 17, 2021

daschuer Aug 18, 2021

Holzhaus Aug 17, 2021 •

edited

Loading

Holzhaus Aug 17, 2021

daschuer Aug 18, 2021

Holzhaus Sep 8, 2021

daschuer Sep 8, 2021

Holzhaus Aug 17, 2021

daschuer Aug 18, 2021

daschuer commented Aug 18, 2021

Holzhaus left a comment

Holzhaus commented Sep 8, 2021

daschuer commented Sep 8, 2021

	* ES6 based controller mapping system with module support
	* ES6 based controller mapping system

		* Don't allow waveforms to obtain input focus [#4128](https://github.com/mixxxdj/mixxx/pull/4128)
		* Inverted scroll wheel waveform zoom direction to mach other applications [#4195](https://github.com/mixxxdj/mixxx/pull/4195)

	* Ensure that tracks with an invalid bpm are re-analyzed [#2776](https://github.com/mixxxdj/mixxx/pull/2776)
	* Ensure that tracks with an invalid BPM are re-analyzed [#2776](https://github.com/mixxxdj/mixxx/pull/2776)

2.4.0 changelog #4210

2.4.0 changelog #4210

Conversation

daschuer commented Aug 16, 2021

coveralls commented Aug 16, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1142456358

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Swiftb0y Aug 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer commented Aug 16, 2021

Swiftb0y left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Holzhaus Aug 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daschuer commented Aug 18, 2021

Holzhaus left a comment

Choose a reason for hiding this comment

Holzhaus commented Sep 8, 2021

daschuer commented Sep 8, 2021

coveralls commented Aug 16, 2021 •

edited

Loading

Swiftb0y Aug 16, 2021 •

edited

Loading

Holzhaus Aug 17, 2021 •

edited

Loading