-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inverted scroll wheel waveform zoom direction #4195
Conversation
We won't introduce any new preference options in 2.3.x, so this fix or change should go into 2.4.0. |
Users should be able to trust that we will not break their workflows at all in stable releases. We already made that mistake with the microphone ducking knob in 2.2 and the result was a lot of confused users on the forum. Let's not repeat that mistake.
I am in favor of less options. |
If we change it it should work the same everywhere. A config option just causes confusion. @raphabigal Please remove the last commit, rebase and force-push. Thanks. |
@raphabigal Thanks! |
Changed the operators used when zooming through the scroll wheel so that the zoom will follow the default behaviour from each OS correctly.
64c5f92
to
d69f3d6
Compare
Thanks for reviewing! I've removed the latest commit and signed the contributor agreement. |
Pull Request Test Coverage Report for Build 1124981149
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am actually used to the old waveform zoom direction, but I am able to learn the new more intuitive one for new users. No need for s preferences option.
Fixes bug #1876005
The feature to zoom the waveform using the scroll wheel was inverted, when compared to standard behaviour from each OS. This fixes the reported bug.
Due to it having stayed that way for quite a while, some people might actually already be used to the way it is now, so I also added a preference to keep it inverted.