Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTrackMenu: Enable/disable external track collections dynamically #3475

Merged
merged 1 commit into from
Dec 21, 2020
Merged

WTrackMenu: Enable/disable external track collections dynamically #3475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 30 additions & 16 deletions src/widget/wtrackmenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,17 +240,23 @@ void WTrackMenu::createActions() {
this,
&WTrackMenu::slotExportMetadataIntoFileTags);

for (const auto& externalTrackCollection :
m_updateInExternalTrackCollections.reserve(
m_pLibrary->trackCollections()->externalCollections().size());
for (auto* const pExternalTrackCollection :
m_pLibrary->trackCollections()->externalCollections()) {
UpdateExternalTrackCollection updateInExternalTrackCollection;
updateInExternalTrackCollection.externalTrackCollection = externalTrackCollection;
updateInExternalTrackCollection.action = new QAction(externalTrackCollection->name(), m_pMetadataMenu);
updateInExternalTrackCollection.action->setToolTip(externalTrackCollection->description());
updateInExternalTrackCollection.externalTrackCollection = pExternalTrackCollection;
updateInExternalTrackCollection.action = new QAction(
pExternalTrackCollection->name(), m_pMetadataMenu);
updateInExternalTrackCollection.action->setToolTip(
pExternalTrackCollection->description());
m_updateInExternalTrackCollections += updateInExternalTrackCollection;
auto externalTrackCollectionPtr = updateInExternalTrackCollection.externalTrackCollection;
connect(updateInExternalTrackCollection.action, &QAction::triggered, this, [this, externalTrackCollectionPtr] {
slotUpdateExternalTrackCollection(externalTrackCollectionPtr);
});
connect(updateInExternalTrackCollection.action,
&QAction::triggered,
this,
[this, pExternalTrackCollection] {
slotUpdateExternalTrackCollection(pExternalTrackCollection);
});
}
}

Expand Down Expand Up @@ -423,17 +429,25 @@ void WTrackMenu::setupActions() {

for (const auto& updateInExternalTrackCollection :
qAsConst(m_updateInExternalTrackCollections)) {
ExternalTrackCollection* externalTrackCollection =
updateInExternalTrackCollection.externalTrackCollection;
if (externalTrackCollection) {
updateInExternalTrackCollection.action->setEnabled(
externalTrackCollection->isConnected());
m_pMetadataUpdateExternalCollectionsMenu->addAction(
updateInExternalTrackCollection.action);
}
m_pMetadataUpdateExternalCollectionsMenu->addAction(
updateInExternalTrackCollection.action);
}
if (!m_pMetadataUpdateExternalCollectionsMenu->isEmpty()) {
m_pMetadataMenu->addMenu(m_pMetadataUpdateExternalCollectionsMenu);
// Enable/disable entries depending on the connection status
// that may change at runtime.
connect(m_pMetadataUpdateExternalCollectionsMenu,
&QMenu::aboutToShow,
this,
[this] {
for (const auto& updateInExternalTrackCollection :
qAsConst(m_updateInExternalTrackCollections)) {
updateInExternalTrackCollection.action->setEnabled(
updateInExternalTrackCollection
.externalTrackCollection
->isConnected());
}
});
}

m_pMetadataMenu->addMenu(m_pCoverMenu);
Expand Down