Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTrackMenu: Enable/disable external track collections dynamically #3475

Merged
merged 1 commit into from
Dec 21, 2020
Merged

WTrackMenu: Enable/disable external track collections dynamically #3475

merged 1 commit into from
Dec 21, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Dec 21, 2020

The current implementation didn't consider that connecting to an external service takes time.

The entries in the "Update external collections" submenu remained disabled forever if WTrackMenu was constructed before the connection had been established. Now this is checked every time when the submenu is actually shown.

Only affects the aoide integration. New version approaching soon, hopefully.

@uklotzde uklotzde added this to the 2.4.0 milestone Dec 21, 2020
@github-actions github-actions bot added the ui label Dec 21, 2020
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer
Copy link
Member

Waiting for ci

@ronso0 ronso0 merged commit 08cbdc7 into mixxxdj:main Dec 21, 2020
@uklotzde uklotzde deleted the wtrackmenu-external-trackcollections branch December 22, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants