Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize TrackTableBackgroundColorOpacity from skins #2545

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Customize TrackTableBackgroundColorOpacity from skins #2545

merged 1 commit into from
Apr 9, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Mar 12, 2020

Based on PR #2538 Ready for review now after prerequisite PR has been merged.

As suggested by @ronso0 here: #2539 (comment)

I'm not sure about the name TrackColorBackgroundOpacity. As an alternative this parameter could also be applied to the background color of the cover image that will be introduced in #2524. I don't use track colors and this would better fit my use case. More generic name is now TrackTableBackgroundColorOpacity.

Naming rationale:

  • it is applied to the track table
  • it controls the alpha channel (= opacity) of the background color
  • the background color might be chosen from either the track color or the cover art background/preview color.

Due to many dependencies the implementation required more changes than expected. If we ever need more customizable parameters then we should rethink the design. But for now this works and should be approachable.

@uklotzde uklotzde added the skins label Mar 12, 2020
@uklotzde uklotzde added this to the 2.3.0 milestone Mar 12, 2020
@uklotzde uklotzde changed the title [WiP] Customize TrackColorBackgroundOpacity from skin [WiP] Customize TrackColorBackgroundOpacity from skins Mar 12, 2020
@uklotzde uklotzde changed the title [WiP] Customize TrackColorBackgroundOpacity from skins [WiP] Customize TrackTableBackgroundColorOpacity from skins Mar 16, 2020
@ronso0
Copy link
Member

ronso0 commented Mar 23, 2020

Works as expected. Thx!
For later on it'll be helpful to set the text color, as well, to allow daylight schemes/skins having much more opaque track colors and an individually contrasting track font.

@uklotzde uklotzde changed the title [WiP] Customize TrackTableBackgroundColorOpacity from skins Customize TrackTableBackgroundColorOpacity from skins Apr 6, 2020
@Be-ing Be-ing merged commit 1735f60 into mixxxdj:master Apr 9, 2020
@Be-ing
Copy link
Contributor

Be-ing commented Apr 9, 2020

LGTM thanks. I'll leave it to @ronso0 to adjust the values in another PR if desired.

@uklotzde uklotzde deleted the trackcolorbackgroundopacity branch April 9, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants