Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track colors make text unreadable with certain QT themes #10061

Open
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Open

Track colors make text unreadable with certain QT themes #10061

mixxxbot opened this issue Aug 23, 2022 · 5 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ngmstr
Date: 2020-07-22T21:01:19Z
Status: New
Importance: Undecided
Launchpad Issue: lp1888573
Attachments: [Library tracks with different Qt themes](https://bugs.launchpad.net/bugs/1888573/+attachment/5395030/+files/Library tracks with different Qt themes)


Mixxx version: 2.4.0-alpha-pre (build master r7476)
OS: Manjaro i3 Edition
Qt verson: 5.15.0

The problem:
With certain Qt themes enabled (e.g. kvantum, which I believe is the default on this OS), all tracks which have a color assigned are displayed incorrectly in the library view.
Almost all columns have a solid fully saturated background, making it very hard to read e.g. white text for a yellow track.
On some skins, the normal coloring can be seen in certain places.
The issue seems to occur with all built-in skins.

Changing the skin to Fusion works around the issue but is not a satisfactory solution.
I have attached a screenshot showing the issue

@mixxxbot
Copy link
Collaborator Author

Commented by: ngmstr
Date: 2020-07-22T21:01:19Z
Attachments: [Library tracks with different Qt themes](https://bugs.launchpad.net/mixxx/+bug/1888573/+attachment/5395030/+files/Library tracks with different Qt themes)

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-07-23T14:22:19Z


those are two separate issues:

  1. explicit track color opacity (0.125) set in skins is not respected
    or did you set it opaque manually?
    added in Customize TrackTableBackgroundColorOpacity from skins #2545

  2. explicit table item text color is not respected
    Deere in your case: https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/style.qss#L216

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-07-23T14:25:10Z


maybe related: Qt theme issue in Fedora
FedoraQt/adwaita-qt#126

@mixxxbot
Copy link
Collaborator Author

Commented by: ngmstr
Date: 2020-07-25T19:02:09Z


The skin was left unmodified. I also saw the same issues in the LateNight skin, which is what I'm actually using in the third screenshot. Both of them have the opacity set to 0.125.

I changed it for testing and noticed that it only affected the part where the opacity is correct. i.e. in the third screenshot, the area behind the stars is affected by it, the rest isn't.

It seems to me that it's not the opacity of the entire row's background is incorrect, but that the individual fields have their own background with the wrong opacity.

I'm not the issues reported for adwaita-qt, not sure if there's any connection (I'm also not using that theme)

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-07-26T15:57:13Z


How does it look like with Mixxx 2.3?

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant