Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight + Deere high pixel density scaling fixes #1858

Merged
merged 8 commits into from
Oct 24, 2018

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 21, 2018

I tried changing WPushButton to use SCALE_ASPECT scalemode by default on Mixxx >= 2.0 skins, but this messed up other skins. Instead I edited LateNight to specify SCALE_ASPECT for all buttons. Along the way I fixed some missing tooltips.
before:
screenshot from 2018-10-20 23-49-18

after:
screenshot from 2018-10-21 15-07-29

@Be-ing Be-ing force-pushed the skin_scalemode branch 3 times, most recently from fb66389 to 48cb386 Compare October 21, 2018 06:11
@Be-ing Be-ing changed the title LateNight high pixel density fixes LateNight high pixel density scaling fixes Oct 21, 2018
@Be-ing Be-ing force-pushed the skin_scalemode branch 2 times, most recently from 6ce8603 to cc1b7e6 Compare October 21, 2018 20:07
@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 21, 2018

There were more buttons to fix than I thought when I looked closer. I think I took care of them all now.

@uklotzde uklotzde added this to the 2.2.0 milestone Oct 22, 2018
<Template src="skin:button_2state_right.xml">
<SetVariable name="TooltipId">sync_enabled</SetVariable>
<SetVariable name="ObjectName">SyncToggleButton</SetVariable>
<SetVariable name="Size">52f,22f</SetVariable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 52f,26f as the icon is 52x26px. So 22px was wrong before (but not computed). Now, with streth_aspect the button is squeezed (44x22):
latenight_sync

@ronso0
Copy link
Member

ronso0 commented Oct 22, 2018

FX expand labels are shifted down for some reason. Padding in style.qss wouldn't help.

@ronso0
Copy link
Member

ronso0 commented Oct 22, 2018

d9dd1c9 fixes the layout when Super knobs are visible.
Also keeps the FX units from expanding unnecessarily.

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 24, 2018

@ronso0 ready for merge?

@Be-ing Be-ing changed the title LateNight high pixel density scaling fixes LateNight + Deere high pixel density scaling fixes Oct 24, 2018
@ronso0
Copy link
Member

ronso0 commented Oct 24, 2018

@Be-ing I see you reverted the minimum size to 1280px
Also you mentioned a scaling problem with your 3840px UHD-1 screen in #1754 that indicates Qt autoscaling uses factor 3.
I doubt this the optimal factor because the layout with big spinnies is squeezd too much IMO on screens large enough to use let's say factor 2.5 or even 2.

Could you post a screenshot how Tango (fullscreen) looks like on that screen?

@ronso0
Copy link
Member

ronso0 commented Oct 24, 2018

The logo appears chopped and not aligned with the GUI toggles
fix: 2c3d1df

@ronso0
Copy link
Member

ronso0 commented Oct 24, 2018

and hotcues can be in group 02edc77

@ronso0
Copy link
Member

ronso0 commented Oct 24, 2018

The rest LGTM!

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 24, 2018

With the current 2.2 branch, LateNight is unusable for me in any configuration. Because it is bigger than my screen, putting it in full screen mode behaves strangely with GNOME. The Mixxx window decorations are gone, but there is a blank space where the GNOME status bar usually is:
screenshot from 2018-10-24 11-56-04
Without full screen mode:
screenshot from 2018-10-24 11-56-23

You are correct that even with this branch, with 4 decks and 4 effect units is practically unusable on my screen (it would help to get rid of that redundant menu bar...)
screenshot from 2018-10-24 12-10-20
Deere also has trouble fitting on my screen comfortably with 4 decks + 4 effect units:
screenshot from 2018-10-24 12-14-21
Tango is better:
screenshot from 2018-10-24 12-15-27

But other configurations work of LateNight fine on my screen without the excessive minimum window size:
screenshot from 2018-10-24 12-09-23
screenshot from 2018-10-24 12-12-55

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 24, 2018

As noted in my commit message for 1a4c0e7 (please read commit messages when reviewing PRs), 4k (3840 x 2160) with a scale factor of 3.0 is like 1280 x 720.

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 24, 2018

Is this okay to merge, including the minimum size change?

@ronso0
Copy link
Member

ronso0 commented Oct 24, 2018

Yeah LGTM, AFAICT it only affects 1280px and 3840px screens.

@Be-ing Be-ing merged commit e45e77a into mixxxdj:2.2 Oct 24, 2018
@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 24, 2018

Thank you for the review and doing some fixes for me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants