-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LateNight + Deere high pixel density scaling fixes #1858
Conversation
fb66389
to
48cb386
Compare
6ce8603
to
cc1b7e6
Compare
There were more buttons to fix than I thought when I looked closer. I think I took care of them all now. |
<Template src="skin:button_2state_right.xml"> | ||
<SetVariable name="TooltipId">sync_enabled</SetVariable> | ||
<SetVariable name="ObjectName">SyncToggleButton</SetVariable> | ||
<SetVariable name="Size">52f,22f</SetVariable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FX expand labels are shifted down for some reason. Padding in style.qss wouldn't help. |
d9dd1c9 fixes the layout when Super knobs are visible. |
@ronso0 ready for merge? |
@Be-ing I see you reverted the minimum size to 1280px Could you post a screenshot how Tango (fullscreen) looks like on that screen? |
scalemode="STRETCH_ASPECT" is required for smooth scaling with Qt5
(1280 x 720) x 3 == (3840 x 2160, also known as "4k")
plus rename logo SVG file
The logo appears chopped and not aligned with the GUI toggles |
70459a4
to
01748dc
Compare
and hotcues can be in group 02edc77 |
The rest LGTM! |
As noted in my commit message for 1a4c0e7 (please read commit messages when reviewing PRs), 4k (3840 x 2160) with a scale factor of 3.0 is like 1280 x 720. |
Is this okay to merge, including the minimum size change? |
Yeah LGTM, AFAICT it only affects 1280px and 3840px screens. |
Thank you for the review and doing some fixes for me! 👍 |
I tried changing WPushButton to use SCALE_ASPECT scalemode by default on Mixxx >= 2.0 skins, but this messed up other skins. Instead I edited LateNight to specify SCALE_ASPECT for all buttons. Along the way I fixed some missing tooltips.
before:
after: