Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGLOG entries about raised OS requirements #13362

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

daschuer
Copy link
Member

No description provided.

CHANGELOG.md Outdated
@@ -270,6 +270,8 @@
* README: Recommend running buildenvs over sourcing them on Linux [#13071](https://github.com/mixxxdj/mixxx/pull/13071)
* FindSndFile: Link mpg123 in static builds [#13087](https://github.com/mixxxdj/mixxx/pull/13087)
* macOS packaging: Enable app sandbox in ad-hoc-packaged (i.e. non-notarized) bundles too [#12101](https://github.com/mixxxdj/mixxx/pull/12101)
* Drop support for macOS versions earlier than 11, Windows 7 and 8.1 and Ubuntu 20.04 "Focal Fossa" and older.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 8 support and support for Windows 10 builds before 1809 is also dropped.
But I think, that of the mentioned versions, only Windows 7 has a significiant user base nowadays.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@daschuer daschuer added this to the 2.5.0 milestone Jun 12, 2024
@@ -804,6 +804,12 @@
macOS packaging: Enable app sandbox in ad-hoc-packaged (i.e. non-notarized) bundles too
#12101
</li>
<li>
Drop support for macOS versions earlier than 11, Windows 7, Windows 10 versions up to 1803 and Ubuntu 20.04 "Focal Fossa"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Drop support for macOS versions earlier than 11, Windows 7, Windows 10 versions up to 1803 and Ubuntu 20.04 "Focal Fossa"
Drop support for macOS versions earlier than 11
Drop support for Windows versions earlier than Windows 10 build 1809
Drop support for Ubuntu versions earlier than 22.04

Let's write this in consistent style, not "earlier than" and "up to" mixed in one sentence.

@daschuer
Copy link
Member Author

Done and updated with recent changes.

Comment on lines 99 to +102
* Playlists: move tracks with Alt + Up/Down/PageUp/PageDown/Home/End
[#13092](https://github.com/mixxxdj/mixxx/pull/13092)
[#10826](https://github.com/mixxxdj/mixxx/issues/10826)
[#13098](https://github.com/mixxxdj/mixxx/pull/13098)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point is listed twice now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot confirm. Where is the second occurrence?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it, thang you. I was looking for #13098 only

@daschuer
Copy link
Member Author

Done.

@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit cd959a6 into mixxxdj:2.5 Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants