Add track move commands to controls library

[nlw0]

Add track move to controls library by emulating alt+up/down. Depends on #13092

[ronso0]

Thanks for this PR!

Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Code LGTM, just a comment

[ronso0]

unfortunately emitKeyEvent requires the library to be focused, which would limit the use cases (same with the current navigation controls, see #9294, #11285 and others).

Let's send the key event to m_pLibraryWidget directly as this is the only widget that would accept this event (check if is not null)

[nlw0]

All right, I couldn't test yet, does the code look right?

[nlw0]

Sure. I believe I signed it already, though.

[ronso0]

LGTM, just the names need to be changed.

[ronso0]

pre-commit is complaining (didn't take a closer look)

[nlw0]

So I was finally able to test and QApplication::sendEvent did not work the way this is, although it worked when I moved back to emitKeyEvent. What could I be missing?

[ronso0]

Sorry, my mistake:
m_pLibraryWidget is the stacked widget that holds all WTrackTableViews, it won't handle the keypress.

I'll prepare a commit that allows to send the keypress to the current view (if it's a WTrackTableView).

[ronso0]

If you adopt my code suggestion, then rebase (and squash commits) onto main 2.5 then there is WLibrary::getCurrentTrackTableView() available, and you can pick (and also squash) this commit
ab8c1d2
Works nicely!

[ronso0]

@nlw0 Do you have time to rebase, cherry-pick and squash as I suggested above?

Let us know if you don't, then I'd take over soonish in order to get this into 2.5 along with the keyboard improvement.

[nlw0]

Hi, I can look into it again, but I wasn't able to use that commit, how do I check it out? On GitHub it says This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

[nlw0]

The SlotMoveTrack commands don't seem to be on the 2.5 branch yet, should I wait for another branch to be merged first?

[ronso0]

yes, the Alt moves are available in 2.5 https://github.com/mixxxdj/mixxx/blob/2.5/src/widget/wtracktableview.cpp#L867

I think you need to git fetch [mixxx upstream], you'll see that 2.5 has been updated since your last commit.
Just squash your commits so we have only one essential commit with extra the CI fixup commits, then rebase. Since this is a PR commit that should work flawlessly.

[nlw0]

All right I haven''t tested yet but here it is. Hope I didn't mess up anything.

[ronso0]

Yep, looks good, thank you!

[ronso0]

Could you also take care of documenting the new controls in the manual? : )
https://manual.mixxx.org/2.5/en/chapters/appendix/mixxx_controls.html#the-library-controls