Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS packaging: Capitalize bundle and executable name when MACOS_BUNDLE is set (Mixxx.app) #12656

Merged
merged 3 commits into from
Jan 27, 2024
Merged

macOS packaging: Capitalize bundle and executable name when MACOS_BUNDLE is set (Mixxx.app) #12656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee7bfc4
macOS packaging: Capitalize name of bundle (Mixxx.app)
fwcd Jan 27, 2024
933233e
macOS packaging: Define bundle identifier in CMakeLists
fwcd Jan 27, 2024
a81f552
macOS packaging: Set bundle and display name uniformly
fwcd Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1676,7 +1676,8 @@ set(MIXXX_INSTALL_DOCDIR "./doc")
set(MIXXX_INSTALL_LICENSEDIR "./doc")
if (APPLE AND MACOS_BUNDLE)
set(MIXXX_INSTALL_BINDIR "${CMAKE_INSTALL_BINDIR}")
set(MACOS_BUNDLE_NAME mixxx)
set(MACOS_BUNDLE_NAME Mixxx)
set(MACOS_BUNDLE_IDENTIFIER org.mixxx.mixxx)
set(MIXXX_INSTALL_PREFIX "${MACOS_BUNDLE_NAME}.app")
set(MIXXX_INSTALL_DATADIR "${MIXXX_INSTALL_PREFIX}/Contents/Resources")
set(MIXXX_INSTALL_DOCDIR "${MIXXX_INSTALL_DATADIR}")
Expand Down Expand Up @@ -1765,6 +1766,7 @@ if (APPLE)

set_target_properties(mixxx PROPERTIES
MACOSX_BUNDLE true
OUTPUT_NAME "${MACOS_BUNDLE_NAME}"
MACOSX_BUNDLE_INFO_PLIST "${CMAKE_CURRENT_SOURCE_DIR}/packaging/macos/Info.plist.in"
)
endif()
Expand Down
8 changes: 4 additions & 4 deletions packaging/macos/Info.plist.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<plist version="1.0">
<dict>
<key>CFBundleExecutable</key>
<string>mixxx</string>
<string>@MACOS_BUNDLE_NAME@</string>

<key>CFBundleIconFile</key>
<string>application.icns</string>
Expand All @@ -12,13 +12,13 @@
<string>APPL</string>

<key>CFBundleIdentifier</key>
<string>org.mixxx.mixxx</string>
<string>@MACOS_BUNDLE_IDENTIFIER@</string>

<key>CFBundleName</key>
<string>Mixxx</string>
<string>@MACOS_BUNDLE_NAME@</string>

<key>CFBundleDisplayName</key>
<string>Mixxx</string>
<string>@MACOS_BUNDLE_NAME@</string>

<key>CFBundleVersion</key>
<string>@MACOS_BUNDLE_VERSION@</string>
Expand Down
Loading