macOS packaging: Capitalize bundle and executable name when MACOS_BUNDLE is set (Mixxx.app)
#12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now capitalize everywhere, we can simplify this
daschuer
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dominant convention on macOS is that both bundle and executable names are capitalized.
Currently our bundles are of the form
mixxx.app/Contents/MacOS/mixxx, though Finder will display the name capitalized since we already set a capitalized display name. With this patch, however, the true name of the bundle will also beMixxx.app/Contents/MacOS/Mixxx.Additionally, this patch sets the bundle identifier in the CMakeLists, for consistency with the way we set the bundle name.