Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences: simplification & layout fixes #12429

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Preferences: simplification & layout fixes #12429

merged 2 commits into from
Dec 14, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 12, 2023

  • remove the useless groupbox in Colors
  • group Interface options (Skin + Misc)
  • simplify Skin layout (needs less h-space, window can be smaller)

@github-actions github-actions bot added the ui label Dec 12, 2023
daschuer
daschuer approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for this nice improvement.

@daschuer daschuer merged commit 5b13308 into mixxxdj:2.4 Dec 14, 2023
11 checks passed
@ronso0 ronso0 deleted the pref-layout-fixes branch December 14, 2023 09:06
@ronso0
Copy link
Member Author

ronso0 commented Dec 14, 2023

Thanks. Follow-up is #12057

@daschuer
Copy link
Member

Is this a regression from this PR?
Do you have an idea where this icon is coming from?

@ronso0
Copy link
Member Author

ronso0 commented Dec 14, 2023

wrong PR, you meant to post in #12424
(no, that was 2.4-beta I fetched earlier)

@daschuer
Copy link
Member

Yes wrong PR, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
accessibility preferences ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer