Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences UI tweaks #12057

Merged
merged 11 commits into from
Feb 11, 2024
Merged

Preferences UI tweaks #12057

merged 11 commits into from
Feb 11, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 3, 2023

Just a few commits off my stash list. See commits for details.

7b83ac7 contains a new tr string, let me know if we should rather merge that to main.

@github-actions github-actions bot added the ui label Oct 3, 2023
@Holzhaus
Copy link
Member

Holzhaus commented Oct 3, 2023

7b83ac7 contains a new tr string, let me know if we should rather merge that to main.

Just wondering, when was the last time we pushed translatable strings to transifex? We probably should do that soon to avoid ending up with a bunch of untranslated stuff when we release 2. 4.

@daschuer
Copy link
Member

daschuer commented Oct 4, 2023

I have just updated the translations.

@daschuer
Copy link
Member

daschuer commented Oct 4, 2023

If the string change is not fixing wrong information, it is better to move it to 2.5. New strings can be added at anytime.

@ronso0
Copy link
Member Author

ronso0 commented Oct 4, 2023

FYI it's no important UI string, just a tooltip for music directories in the Library preferences that are currently not available / invalid.
I don't mind moving the commit.

@daschuer
Copy link
Member

daschuer commented Oct 4, 2023

I have no special demands here, both works for me.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good and looks good. The string is helpful even if it sticks untranslated.
Thank you.

@daschuer daschuer merged commit 8a37340 into mixxxdj:2.4 Feb 11, 2024
11 checks passed
@ronso0 ronso0 deleted the pref-ui-tweaks branch February 11, 2024 12:38
tr("The minimum size of the selected skin is bigger than your "
"screen resolution.");
warningLabel->setText(sizeWarningString);
warningLabel->setText(kWarningIconHtmlString);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning message got lost.
2.4:
grafik
This PR:
grafik
(Screenshots at 200% system-wide zoom)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll prepare a fixup asap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, damn, hopefully the translations have not been dumped, yet.
@daschuer (or whoever is going to push tr) please wait for the fixup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants