-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences UI tweaks #12057
Preferences UI tweaks #12057
Conversation
Just wondering, when was the last time we pushed translatable strings to transifex? We probably should do that soon to avoid ending up with a bunch of untranslated stuff when we release 2. 4. |
I have just updated the translations. |
If the string change is not fixing wrong information, it is better to move it to 2.5. New strings can be added at anytime. |
FYI it's no important UI string, just a tooltip for music directories in the Library preferences that are currently not available / invalid. |
I have no special demands here, both works for me. |
Minimum width is now either width of the links at the bottom or total width of buttons (depends on translations).
by adding QGroupBox 'OpenGL status' (remove the respective label) so the lengthy OpenGL version string can use the entire width
0212838
to
0617e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good and looks good. The string is helpful even if it sticks untranslated.
Thank you.
tr("The minimum size of the selected skin is bigger than your " | ||
"screen resolution."); | ||
warningLabel->setText(sizeWarningString); | ||
warningLabel->setText(kWarningIconHtmlString); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll prepare a fixup asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff, damn, hopefully the translations have not been dumped, yet.
@daschuer (or whoever is going to push tr) please wait for the fixup!
Just a few commits off my stash list. See commits for details.
7b83ac7 contains a new tr string, let me know if we should rather merge that to main.