-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix track color background with Qt6 #12380
Conversation
Looks good to me |
2027974
to
3e0b96f
Compare
Can someone tell if the last commits makes sense? |
The last commit has some implications regarding compile time. It includes unnecessarily headers into all cpp files that are including "src/library/tableitemdelegate.h" |
I have used this: daschuer@7f2c8ed |
3e0b96f
to
866cea5
Compare
+ some small improvements for the table view Shade
866cea5
to
b56244b
Compare
Okay, thanks. I reverted that header commit. Ready to roll if it's been confirmed to fix the issue on Windows, too. |
I tested on Win11. The track color, checkbbox and padlock symbol appear as expected on all skins! But there seems to be a missing refresh/update, after the color unassign operation. The update happens delayed, when I select another row: |
Thanks for testing. The refresh issue occurs also in 2.4 IIRC, and it affects the entire row. This PR only touches the BPM delegate, and the new one, of course. |
Ok, if it's no regression - than we can merge this! Thank you! |
Fixes #12355 for me, both with Qt5 and Qt6 (note I didn't see #11630).
So, the issue is that 1ef4e4d
clears the track color set via BackgroundRole.
Seems it sufficient to call
TableItemDelegate::paintItemBackground
like it's done for the other delegates.I don't know how to apply this to the Played checkbox (it's a native QTableView::indicator), so I added a delegate for that, too. Dumb c/p from BPM delegate, without the editor.
Please check if that works also on Windows and macOS @fwcd @JoergAtGithub
Should look good with all skins.