regression in main: library track colors no longer appear

[ywwg]

Bug Description

Track colors have disappeared from the track listing in the main branch. I did a git bisect and the commit that broke it was the QT6 checkbox fix: 1ef4e4d

@fwcd can you take a look?

Version

HEAD

OS

Ubuntu 22.04

[ywwg]

broken:

working:

[fwcd]

Huh, that's very weird. The way Qt applies styles remains a mystery to me.

@ronso0 Any ideas?

[ronso0]

So, border 0px for #LibraryBPMButton::item is fixing the BPM button, and WTrackTableView::item is actually just for the Played checkbox. Disabling the latter should restore the track color bg, except for the BPM column. Is that the case?

[ronso0]

Guess we also should take a look at the delegates' paint code. Maybe there's room for optimization.

Oh the Played column doesn't have a delegate.

[ywwg]

Setting only

#LibraryBPMButton::item {
border: 0px;
}

hilariously fixes it for the rest of the row but not the bpm column:

[ronso0]

yes, because WTrackTableView::item is the only way to select the Played column but addresses ALL items except the delegates.

I tried a few qss mods last night, but none would fix the icon while having the bg color.
I guess we need to look for the related Qt bug.

[fwcd]

Does the highlight color issue occur in Qt 5 builds of main too?

[ronso0]

Yep, same with Qt5.