Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe Sync Lock with Dynamic Tempo #589

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Describe Sync Lock with Dynamic Tempo #589

merged 3 commits into from
Nov 6, 2023

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Oct 10, 2023 •
edited by ronso0
Loading

@daschuer daschuer added this to the 2.4 milestone Oct 10, 2023
@daschuer daschuer mentioned this pull request Oct 10, 2023
Merged
@ronso0
Copy link
Member

ronso0 commented Oct 11, 2023

I think we need to merge 2.3 into 2.4 first (I already tried to do so but didn't manage to look into the conflicts, yet), than the link fix commits are obsolete.

ronso0
ronso0 requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typos/rephrasing

source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
source/chapters/djing_with_mixxx.rst Outdated Show resolved Hide resolved
@daschuer
Copy link
Member Author

Thank you.

@daschuer
Copy link
Member Author

OK 2.3 is merge to 2.4, translations are updated and this is rebased on top of all.

@ronso0
Copy link
Member

ronso0 commented Oct 11, 2023

Cool.
I just tried to enhance the text flow. Even though I think the text is comprehensible I doubt I have a 'naive look' at the text, i.e. put myself into a noob's position.
Someone else should double-check before we merge this.

@daschuer
Copy link
Member Author

@ywwg Can you have a look?

ywwg
ywwg approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no notes! Well-described and written. Thank you.

@ronso0
Copy link
Member

ronso0 commented Nov 6, 2023

Thanks for your review!

@ronso0 ronso0 merged commit d33a5df into mixxxdj:2.4 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 requested changes

@ywwg ywwg ywwg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @ronso0 @ywwg